Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bundle install with --with option is dispensable in this case #629

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: bundle install with --with option is dispensable in this case #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df2035
chore: `bundle install` with `--with` option is dispensable in this case
sato11 Jan 17, 2023
c60268a
Merge branch 'main' into the-with-flag-is-dispensable
shrutiburman May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
run: bundle add rubocop --version "~> 1.24.1" --group "development" --skip-install
if: ${{ matrix.ruby != '2.4' }}

- run: bundle install --with development
- run: bundle install
- run: bundle exec rake install

- name: Run linter
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
source 'https://rubygems.org'
gem 'simplecov', require: false, group: :test
gem 'simplecov', require: false
gemspec
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ githooks:
ln -sf ../../githooks/pre-commit .git/hooks/pre-commit

install:
bundle install --with development; bundle exec rake install
bundle install; bundle exec rake install

test:
bundle exec rake spec
Expand Down