chore: remove ostruct and benchmark from gemspec #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
Follow-up to #738 and #739.
From what I saw,
ostruct
was added to the gemspec because it was needed by arubocop
fromatter as part of thetest-and-deploy.yml
GitHub CI workflow, which failed on a deprecation warning becaueostruct
will removed from the Ruby std lib in v3.5.0 and therefore has to be installed explicitly.Adding these dependencies to Twilio's gemspec does "solve" the problem by making the gems available, but it also indicates that they are required fo Twilio to function, which I don't think is true; I didn't see any references to
OpenStruct
in the Twilio source, and the gem was ultimately loaded byrubocop
as part of a CI step (whererubcop
is actually added to the bundle individually, here); thus,ostruct
seems to be required by the Twilio CI workflow but not by Twilio itself. (And I assume the same is true forbenchmark
.)This PR removes
ostruct
andbenchmark
from the Twilio gemspec, which both avoids the confusion that they are required for Twilio and also prevents future users of this gem from having to install those dependences, which they do today (though it's currently moot sinceostruct
is still part of the Ruby std lib, so they get it anyway). It keeps the gems defined in the Gemfile, which should keep them available to bundle-aware operations like the CI workflow.Note that the real test of this will be re-running "Test (ruby-head)" which was where the errors were first seen.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.