feat: implement SetSearchPaths #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements SetSearchPaths matching the C function proj_context_set_search_paths, which allows to set the locations that PROJ will use to search the PROJ data files.
|
Thank you for a very nice PR! Would you like a new version of go-proj tagged now that includes this, or do you have more PRs in the pipeline? |
|
This is the only PR I'm planning for now. If you want to create the tag please go ahead :) |
|
OK, I've tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change
This PR implements a
SetSearchPathsfunction on theContextobject to allow users of the library to instruct Proj to search for data files in the provided locations.To perform this operation, this function calls the underlying C function proj_context_set_search_paths passing as input the required parameters:
nilif the number of paths is zeroWhy this change
Without this change, any software depending on this library needs to make sure that the
PROJ_DATAenvironment variable is set. This change enables software to programmatically set the data discovery paths per each individual context without relying on global environment variables.Testing
I have tested this function in a program I am developing and checked it worked. I have also written a unit test, although it is of limited usefulness since the C function does not return any error.