Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @ember/test-waiters to dependencies #993

Merged
merged 3 commits into from
Jan 9, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust ember-try config and compatibility
  • Loading branch information
gorner committed Dec 10, 2024
commit c57b9629308309bbef35efa05da335502f88bcff
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@

----

* Ember.js v3.20 or above
* Ember.js v3.20 through v5.12
* Ember CLI v3.13 or above
* Node.js v12 or above

@@ -37,7 +37,7 @@ Just drop an `<AttachTooltip/>` or `<AttachPopover/>` in a parent and your float
<button class="other-button">
No click me!

<AttachPopover
<AttachPopover
@class='ember-attacher'
@hideOn='click'
@isShown={{true}}
@@ -93,11 +93,11 @@ Below is a list of all available options, along with their defaults.

// Whether or not an arrow will be displayed next to the attachment.
arrow: false,

// Add listeners that will automatically call an update function
// Pass `true` to use the Floating UI default options or Options object to override them
// Example: { ancestorScroll: false }
// For more details see https://floating-ui.com/docs/autoUpdate
// For more details see https://floating-ui.com/docs/autoUpdate
autoUpdate: false,

// A class that will be applied to the attachment.
@@ -178,8 +178,8 @@ Below is a list of all available options, along with their defaults.
// showing and hiding of popovers and tooltips.
useCapture: false,

// The default padding if collision happens. Set "false" if no collision prevention needed
overflowPadding: 5
// The default padding if collision happens. Set "false" if no collision prevention needed
overflowPadding: 5
}
```

@@ -265,7 +265,7 @@ test('example', async function(assert) {
<button id="toggle">
Click me, captain!

<AttachPopover
<AttachPopover
@id='attachment'
@hideOn='click'
@showOn='click'
9 changes: 9 additions & 0 deletions tests/dummy/config/ember-try.js
Original file line number Diff line number Diff line change
@@ -32,8 +32,17 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-5.12',
npm: {
devDependencies: {
'ember-source': '~5.12.0',
},
},
},
{
name: 'ember-release',
allowedToFail: true,
npm: {
devDependencies: {
'ember-source': await getChannelURL('release'),