Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyberschool-errorteaplate:0.1.3 #1742

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ErrorTeaPot
Copy link

I am submitting

  • a new package
  • an update for a package

This is a template based on my school colors and logos. It can be useful at first for the people in my school since it will be ready to use, but I have made it modular enough to change logos, titles,...

The version is not 0.1.0 but 0.1.3 because I have changed basic things but my CI requires new version numbers.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does

  • added a typst.toml file with all required keys

  • added a README.md with documentation for my package

  • have chosen a license and added a LICENSE file or linked one in my README.md

  • tested my package locally on my system and it worked

  • excluded PDFs or README images, if any, but not the LICENSE

  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Feb 17, 2025
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few comments. Can you please also fix the errors and warnings reported by CI?

@@ -0,0 +1,28 @@
[package]
name = "cyberschool-template"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this is an official package, I will ask you to change the name. It should be unique enough for another alternative implementation to co-exist without giving your package an advantage. The most common strategy is to add a distinctive adjective to the institution name.

If the package is officially endorsed by the school staff, a representative should send an email to hello@typst.app stating so.

Also, I would remove the template suffix, it feels redundant. It should be clear enough that this is a template with the context.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the name on this commit

name = "cyberschool-template"
version = "0.1.3"
entrypoint = "src/lib.typ"
authors = ["ErrorTeaPot contact.233s7@simplelogin.com"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your email address should be between chevrons. Also, if you are using a SimpleLogin address to avoid spam, know that you are not forced to give an email address, you can just have your username here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the email address on this commit

@ErrorTeaPot
Copy link
Author

Since I have changed the package name what is the process regarding the directory name in packages/preview ? Should I just rename it ?

@elegaanz
Copy link
Member

Yes, you should rename the directory too.

@typst-package-check typst-package-check bot changed the title cyberschool-template:0.1.3 cyberschool-errorteaplate:0.1.3 Feb 18, 2025
@ErrorTeaPot
Copy link
Author

The second CI check (@preview/cyberschool-errorteaplate) checks if the package is into the repos. Since it is my first upload (at all and of this package) what should I do ?

@elegaanz
Copy link
Member

The CI is able to resolve the package from the template, the issue here is that you are using the wrong namespace: it should be @preview not @local.

@ErrorTeaPot
Copy link
Author

The package is now passing the CI tests, do I have other things to change ?

@elegaanz
Copy link
Member

elegaanz commented Feb 19, 2025

It would be nice if you could update your README file to have something else than a placeholder. It doesn't have to be very long, but it should explain what that package is, and optionally how to use it and show what it looks like. Same goes for the changelog, you should either fill it or remove it if you don't plan to actually use it.

@ErrorTeaPot
Copy link
Author

I have updated it, is it fine as it is ?

@ErrorTeaPot
Copy link
Author

@elegaanz Any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants