chore: update to ember-cli 4.7

Tom Zellman · tzellman · commit 65097b74e93b · 2022-10-04T11:28:33.000-04:00
diff --git a/.ember-cli b/.ember-cli
@@ -5,5 +5,11 @@
 
     Setting `disableAnalytics` to true will prevent any data from being sent.
   */
-  "disableAnalytics": false
+  "disableAnalytics": false,
+
+  /**
+  Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
+  rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
+  */
+  "isTypeScriptProject": false
 }
diff --git a/.eslintignore b/.eslintignore
@@ -19,4 +19,7 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,79 @@
+name: CI
+
+on:
+    push:
+        branches:
+            - main
+            - master
+    pull_request: {}
+
+concurrency:
+    group: ci-${{ github.head_ref || github.ref }}
+    cancel-in-progress: true
+
+jobs:
+    test:
+        name: "Tests"
+        runs-on: ubuntu-latest
+        timeout-minutes: 10
+
+        steps:
+            - uses: actions/checkout@v3
+            - name: Install Node
+              uses: actions/setup-node@v3
+              with:
+                  node-version: 14.x
+                  cache: npm
+            - name: Install Dependencies
+              run: npm ci
+            - name: Lint
+              run: npm run lint
+            - name: Run Tests
+              run: npm run test:ember
+
+    floating:
+        name: "Floating Dependencies"
+        runs-on: ubuntu-latest
+        timeout-minutes: 10
+
+        steps:
+            - uses: actions/checkout@v3
+            - uses: actions/setup-node@v3
+              with:
+                  node-version: 14.x
+                  cache: npm
+            - name: Install Dependencies
+              run: npm install --no-shrinkwrap
+            - name: Run Tests
+              run: npm run test:ember
+
+    try-scenarios:
+        name: ${{ matrix.try-scenario }}
+        runs-on: ubuntu-latest
+        needs: "test"
+        timeout-minutes: 10
+
+        strategy:
+            fail-fast: false
+            matrix:
+                try-scenario:
+                    - ember-lts-3.24
+                    - ember-lts-3.28
+                    - ember-release
+                    - ember-beta
+                    - ember-canary
+                    - ember-classic
+                    - embroider-safe
+                    - embroider-optimized
+
+        steps:
+            - uses: actions/checkout@v3
+            - name: Install Node
+              uses: actions/setup-node@v3
+              with:
+                  node-version: 14.x
+                  cache: npm
+            - name: Install Dependencies
+              run: npm ci
+            - name: Run Tests
+              run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
diff --git a/.gitignore b/.gitignore
@@ -24,5 +24,10 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
 /package-lock.json.ember-try
+/yarn.lock.ember-try
+
+# broccoli-debug
+/DEBUG/
diff --git a/.npmignore b/.npmignore
@@ -37,4 +37,7 @@ commitlint.config.js
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
diff --git a/.prettierignore b/.prettierignore
@@ -14,8 +14,12 @@
 /coverage/
 !.*
 .eslintcache
+.lint-todo/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -22,4 +22,4 @@
 -   `ember serve`
 -   Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
+For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
diff --git a/README.md b/README.md
@@ -65,8 +65,9 @@ The `trigger-event` modifier allows you to trigger an event when the element is
 
 ## Compatibility
 
--   Ember.js v3.20 or above
--   Node.js v12 or above
+-   Ember.js v3.24 or above
+-   Ember CLI v3.24 or above
+-   Node.js v14 or above
 
 ## Contributing
 
diff --git a/config/ember-try.js b/config/ember-try.js
@@ -7,18 +7,18 @@ module.exports = async function () {
     return {
         scenarios: [
             {
-                name: 'ember-lts-3.20',
+                name: 'ember-lts-3.24',
                 npm: {
                     devDependencies: {
-                        'ember-source': '~3.20.5'
+                        'ember-source': '~3.24.3'
                     }
                 }
             },
             {
-                name: 'ember-lts-3.24',
+                name: 'ember-lts-3.28',
                 npm: {
                     devDependencies: {
-                        'ember-source': '~3.24.3'
+                        'ember-source': '~3.28.0'
                     }
                 }
             },
@@ -46,19 +46,6 @@ module.exports = async function () {
                     }
                 }
             },
-            {
-                name: 'ember-default-with-jquery',
-                env: {
-                    EMBER_OPTIONAL_FEATURES: JSON.stringify({
-                        'jquery-integration': true
-                    })
-                },
-                npm: {
-                    devDependencies: {
-                        '@ember/jquery': '^1.1.0'
-                    }
-                }
-            },
             {
                 name: 'ember-classic',
                 env: {
diff --git a/package.json b/package.json
@@ -26,64 +26,63 @@
     "test:ember-compatibility": "ember try:each"
   },
   "dependencies": {
-    "ember-cli-babel": "^7.26.6",
-    "ember-cli-htmlbars": "^6.0.0"
+    "ember-cli-babel": "^7.26.11",
+    "ember-cli-htmlbars": "^6.1.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^13.2.1",
     "@commitlint/config-conventional": "^13.2.0",
     "@ember/optional-features": "^2.0.0",
     "@ember/render-modifiers": "^1.0.2",
-    "@ember/test-helpers": "^2.5.0",
-    "@embroider/test-setup": "^0.47.1",
-    "@glimmer/component": "^1.0.4",
-    "@glimmer/tracking": "^1.0.4",
+    "@ember/test-helpers": "^2.8.1",
+    "@embroider/test-setup": "^1.8.3",
+    "@glimmer/component": "^1.1.2",
+    "@glimmer/tracking": "^1.1.2",
     "autoprefixer": "^10.4.0",
     "babel-eslint": "^10.1.0",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-auto-import": "^1.12.0",
-    "ember-cli": "~3.28.3",
+    "ember-auto-import": "^2.4.2",
+    "ember-cli": "~4.7.0",
     "ember-cli-code-coverage": "^1.0.3",
-    "ember-cli-dependency-checker": "^3.2.0",
+    "ember-cli-dependency-checker": "^3.3.1",
     "ember-cli-github-pages": "^0.2.2",
     "ember-cli-inject-live-reload": "^2.1.0",
     "ember-cli-postcss": "^7.0.2",
     "ember-cli-sri": "^2.1.1",
     "ember-cli-terser": "^4.0.2",
     "ember-composable-helpers": "^4.5.0",
     "ember-disable-prototype-extensions": "^1.1.3",
-    "ember-export-application-global": "^2.0.1",
     "ember-load-initializers": "^2.1.2",
-    "ember-maybe-import-regenerator": "^1.0.0",
     "ember-modifier": "^3.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^5.1.5",
     "ember-resolver": "^8.0.3",
-    "ember-source": "~3.28.4",
+    "ember-source": "~4.7.0",
     "ember-source-channel-url": "^3.0.0",
-    "ember-template-lint": "^3.11.0",
+    "ember-template-lint": "^4.14.0",
     "ember-truth-helpers": "^3.0.0",
-    "ember-try": "^1.4.0",
+    "ember-try": "^2.0.0",
     "eslint": "^7.32.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-ember": "^10.5.7",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-plugin-ember": "^11.0.6",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-qunit": "^7.0.0",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-qunit": "^7.3.1",
     "husky": "^4.3.8",
     "loader.js": "^4.7.0",
     "micromatch": "^4.0.4",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.4.1",
+    "prettier": "^2.7.1",
     "pretty-quick": "^3.1.1",
-    "qunit": "^2.17.2",
+    "qunit": "^2.19.1",
     "qunit-dom": "^2.0.0",
     "rimraf": "^3.0.2",
     "tailwindcss": "^2.2.17",
-    "tracked-built-ins": "^1.1.1"
+    "tracked-built-ins": "^1.1.1",
+    "webpack": "^5.74.0"
   },
   "engines": {
-    "node": "12.* || 14.* || >= 16"
+    "node": "14.* || >= 16"
   },
   "ember": {
     "edition": "octane"
diff --git a/tests/dummy/app/index.html b/tests/dummy/app/index.html
@@ -1,25 +1,24 @@
 <!DOCTYPE html>
 <html>
-  <head>
-    <meta charset="utf-8">
-    <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Dummy</title>
-    <meta name="description" content="">
-    <meta name="viewport" content="width=device-width, initial-scale=1">
+    <head>
+        <meta charset="utf-8" />
+        <title>Dummy</title>
+        <meta name="description" content="" />
+        <meta name="viewport" content="width=device-width, initial-scale=1" />
 
-    {{content-for "head"}}
+        {{content-for "head"}}
 
-    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
-    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css">
+        <link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css" />
+        <link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css" />
 
-    {{content-for "head-footer"}}
-  </head>
-  <body>
-    {{content-for "body"}}
+        {{content-for "head-footer"}}
+    </head>
+    <body>
+        {{content-for "body"}}
 
-    <script src="{{rootURL}}assets/vendor.js"></script>
-    <script src="{{rootURL}}assets/dummy.js"></script>
+        <script src="{{rootURL}}assets/vendor.js"></script>
+        <script src="{{rootURL}}assets/dummy.js"></script>
 
-    {{content-for "body-footer"}}
-  </body>
+        {{content-for "body-footer"}}
+    </body>
 </html>
diff --git a/tests/dummy/config/ember-cli-update.json b/tests/dummy/config/ember-cli-update.json
@@ -3,7 +3,7 @@
     "packages": [
         {
             "name": "ember-cli",
-            "version": "3.28.3",
+            "version": "4.7.0",
             "blueprints": [
                 {
                     "name": "addon",
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -10,10 +10,6 @@ module.exports = function (environment) {
             FEATURES: {
                 // Here you can enable experimental features on an ember canary build
                 // e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
-            },
-            EXTEND_PROTOTYPES: {
-                // Prevent Ember Data from overriding Date.parse.
-                Date: false
             }
         },
 
diff --git a/tests/dummy/config/targets.js b/tests/dummy/config/targets.js
@@ -2,21 +2,6 @@
 
 const browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'];
 
-// Ember's browser support policy is changing, and IE11 support will end in
-// v4.0 onwards.
-//
-// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
-//
-// If you need IE11 support on a version of Ember that still offers support
-// for it, uncomment the code block below.
-//
-// const isCI = Boolean(process.env.CI);
-// const isProduction = process.env.EMBER_ENV === 'production';
-//
-// if (isCI || isProduction) {
-//   browsers.push('ie 11');
-// }
-
 module.exports = {
     browsers
 };
diff --git a/tests/helpers/.gitkeep b/tests/helpers/.gitkeep
diff --git a/tests/helpers/index.js b/tests/helpers/index.js
diff --git a/tests/index.html b/tests/index.html

Original file line number	Diff line number	Diff line change
`@@ -7,18 +7,18 @@ module.exports = async function () {`
`7`	`7`	`return {`
`8`	`8`	`scenarios: [`
`9`	`9`	`{`
`10`		`- name: 'ember-lts-3.20',`
	`10`	`+ name: 'ember-lts-3.24',`
`11`	`11`	`npm: {`
`12`	`12`	`devDependencies: {`
`13`		`- 'ember-source': '~3.20.5'`
	`13`	`+ 'ember-source': '~3.24.3'`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`},`
`17`	`17`	`{`
`18`		`- name: 'ember-lts-3.24',`
	`18`	`+ name: 'ember-lts-3.28',`
`19`	`19`	`npm: {`
`20`	`20`	`devDependencies: {`
`21`		`- 'ember-source': '~3.24.3'`
	`21`	`+ 'ember-source': '~3.28.0'`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`},`
`@@ -46,19 +46,6 @@ module.exports = async function () {`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`	`},`
`49`		`- {`
`50`		`- name: 'ember-default-with-jquery',`
`51`		`- env: {`
`52`		`- EMBER_OPTIONAL_FEATURES: JSON.stringify({`
`53`		`- 'jquery-integration': true`
`54`		`- })`
`55`		`- },`
`56`		`- npm: {`
`57`		`- devDependencies: {`
`58`		`- '@ember/jquery': '^1.1.0'`
`59`		`- }`
`60`		`- }`
`61`		`- },`
`62`	`49`	`{`
`63`	`50`	`name: 'ember-classic',`
`64`	`51`	`env: {`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"packages": [`
`4`	`4`	`{`
`5`	`5`	`"name": "ember-cli",`
`6`		`- "version": "3.28.3",`
	`6`	`+ "version": "4.7.0",`
`7`	`7`	`"blueprints": [`
`8`	`8`	`{`
`9`	`9`	`"name": "addon",`