Remove compiler warning when U_CX_PORT_PRINTF is defined as nothing. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobMeades
changed the title
RobMeades
changed the title
When using uxclient with ubxlib we define U_CX_AT_CONFIG_FILE in order to use our own configuration file. When ubxlib is configured to have no logging at compile-time, so U_CX_PORT_PRINTF is defined to be empty, we get a compiler warning from uCxLogPrintTime() because the stack variables in that function are no longer used. This PR makes the whole of the body of uCxLogPrintTime() conditional on U_CX_PORT_PRINTF being defined in order to remove the warning.
RobMeades
force-pushed
the
fix_warning_no_logging_rmea
branch
from
f628db3 to
f2f51e9
Compare
|
Thanks for fixing Rob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andreas: just a little tidy up. There may be other ways of doing this, feel free to suggest.
When using
uxclientwithubxlibwe defineU_CX_AT_CONFIG_FILEin order to use our own configuration file. Whenubxlibis configured to have no logging at compile-time, soU_CX_PORT_PRINTFis defined to be empty, we get a compiler warning fromuCxLogPrintTime()because the stack variables in that function are no longer used. This PR makes the whole of the body ofuCxLogPrintTime()conditional onU_CX_PORT_PRINTFbeing defined as something useful in order to remove the warning.