Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new condition cap_generic_hiding #3570

Open
9 tasks done
Yuki2718 opened this issue Mar 9, 2025 · 2 comments
Open
9 tasks done

Add a new condition cap_generic_hiding #3570

Yuki2718 opened this issue Mar 9, 2025 · 2 comments

Comments

@Yuki2718
Copy link

Yuki2718 commented Mar 9, 2025

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

We still keep these and bunch of specific cosmetic filters just for those who have been using uBO since before we enabled generic cosmetic filters by default on mobile:

*##.ad-block
*##.ad-center
*##.ad-slot:not(.adsbox):not(.adsbygoogle)
~lamire.jp,*##.ad-unit:not(.text-ad):not(.textads):not([style^="width: 1px; height: 1px; position: absolute;"])
*##.ad-wrapper
*##.ad_container
*##.ads-wrapper
*##.dfp-ad
*##.ezoic-ad
*##.top-ad-container
*##AMP-AD
*##div[id*="ScriptRoot"]
*##ins.adsbygoogle[data-ad-client]
*##ins.adsbygoogle[data-ad-slot]

Actually they are useful not only to mobile user, but to anyone who disabled generic cosmetics too. And now, if I understand correctly, uBOL does not apply generic cosmetic filters in Optimal mode. For all of them this directive will be useful.

A specific URL where the issue occurs.

E.g. https://github.com/uBlockOrigin/uAssets/issues/21924

Steps to Reproduce

NA

Expected behavior

NA

Actual behavior

NA

uBO version

1.62.0

Browser name and version

Chrome 134.0.6998.36

Operating System and version

Windows 11

@gorhill
Copy link
Member

gorhill commented Mar 9, 2025

for those who have been using uBO since before we enabled generic cosmetic filters by default on mobile

I am pretty sure that when the setting was toggled off by default (March 2024), those who had uBO installed before would still benefit the change since uBO saves only the settings which differ from default state.

As for uBOL, I am confused about how this would help since the lists are compiled at extension building time: how would cap_generic_hiding be used and how would it help?

@Yuki2718
Copy link
Author

Yuki2718 commented Mar 9, 2025

As for uBOL, I am confused about how this would help since the lists are compiled at extension building time: how would cap_generic_hiding be used and how would it help?

Woops, I forgot that. Maybe the value should be false for uBOL. The idea is to limit these filters only to needed congifuration and move from filters-mobile.txt, as they're valuable if you have "Ignore generic cosmetic filters" checked or for chose Optimal mode in uBOL, but not for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants