Merge all script thingies at the package toplevel #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using subcommands at the top of the package is simpler and easier than using individual script submodules. Merger is mostly direct and ad-hoc, there was a minor amount of deduplication (imports and the `file` argument, via parent parsers) but that's about it so there may be opportunities for reducing the size of the runner if someone bothers looking into it.
masklinn
force-pushed
the
single-entry-point
branch
from
619e959 to
f2a2dc8
Compare
Doesn't seem super useful, as the GIL means a cache lock might not get to contend that much. However it might find utility with the free threaded interpreter eventually. Anyway it's not huge and it's not very complex, although the contextvars API is not great for lazy initialisation. Still even though the initialisation looks like it could lead to redundant inits (similar to the clearing cache which can get multi-cleared) it should be safe: different threads hitting `cache` concurrently will each hit their own lookup failure, and initialise their local cache, and set their personal contextvar. For a var to get double-init would require the same thread to be concurrent with itself, which is not possible. Fixes ua-parser#180
masklinn
force-pushed
the
single-entry-point
branch
from
f2a2dc8 to
792e0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using subcommands at the top of the package is simpler and easier than using individual script submodules.
Merger is mostly direct and ad-hoc, there was a minor amount of deduplication (imports and the
fileargument, via parent parsers) but that's about it so there may be opportunities for reducing the size of the runner if someone bothers looking into it.