This repository was archived by the owner on Dec 22, 2022. It is now read-only.
Use github workflows to run CI #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
force-pushed
the
github_actions
branch
from
f699fad to
a1614bc
Compare
With travis-ci transitioning to a limited credit system after Dec 31st and currently taking hours for jobs to go from queued to completion, I think we'll need to migrate all our CI to github actions
I use a custom docker-compose which includes this anyways. mysql is also necessary for github actions so making this the default.
pgwillia
force-pushed
the
github_actions
branch
from
a8ca4ab to
f14851f
Compare
pgwillia
changed the title
murny
reviewed
Dec 23, 2020
| RAILS_ENV: test | ||
| run: | | ||
| bundle exec rake db:create | ||
| bundle exec rake db:migrate |
There was a problem hiding this comment.
Small tip, I think rails db:schema:load is a bit more performant than doing migrations (Will use the db/schema.rb to provision DB instead of running all the migrations). But that's totally up to you 👍
There was a problem hiding this comment.
💯 You've definitely warned me about this before and I had hoped to fix it. Right now there is some seeding that tests depend on that is set up by migrations. It's a pain to deal with and I've learned my lesson.
#1932
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With travis-ci transitioning to a limited credit system after Dec 31st and currently taking hours for jobs to go from queued to completion, I think we'll need to migrate all our CI to github actions
Related to #2121
What's New