Skip to content

fix: JoinRuns input order #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: JoinRuns input order #118

merged 1 commit into from
Aug 16, 2024

Conversation

zyangbi
Copy link
Contributor

@zyangbi zyangbi commented Aug 16, 2024

Iterate over the event list and assign firstModel and secondModel based on the presence of respective keys in the data. Avoiding KeyError when the order of events change.

@engshahrad engshahrad self-requested a review August 16, 2024 02:22
engshahrad
engshahrad approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@engshahrad engshahrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this. LGTM.

@engshahrad engshahrad linked an issue Aug 16, 2024 that may be closed by this pull request
Consider Order of Input Events in RegressionTuningJoinRuns #119
Closed
@engshahrad engshahrad merged commit 2758990 into ubc-cirrus-lab:main Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engshahrad engshahrad engshahrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Order of Input Events in RegressionTuningJoinRuns
2 participants
@zyangbi @engshahrad