Skip to content

Remove cast property from SwiftType #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

sidepelican
Copy link
Collaborator

The SwiftType has a cast property, which is a temporary value used only in certain situations and need not be stored.
Remove it because it is structurally unnatural.

@sidepelican sidepelican requested review from uhooi and fummicc1 April 16, 2025 08:44
Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sidepelican sidepelican merged commit 6bc6b81 into uber:master Apr 21, 2025
5 checks passed
@sidepelican sidepelican deleted the remove-cast branch April 21, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants