Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling when no votes exist for a snap #59

Closed
tim-hm opened this issue Jan 24, 2024 · 1 comment
Closed

Improve handling when no votes exist for a snap #59

tim-hm opened this issue Jan 24, 2024 · 1 comment
Assignees
@tim-hm
Labels
bug Something isn't working

Comments

@tim-hm
Copy link
Contributor

tim-hm commented Jan 24, 2024

The call to get app ratings returns an internal server error if there are no votes for the specific snap_id. This is caused by using fetch_one in get_votes_by_snap_id which throws sqlx::RowNotFound if no votes are in the database.
@tim-hm tim-hm added the bug Something isn't working label Jan 24, 2024
@tim-hm tim-hm self-assigned this Jan 24, 2024
@ZoopOTheGoop
Copy link
Contributor

This was fixed in 35aa0dfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-hm tim-hm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tim-hm @ZoopOTheGoop