From 6485eebc59ddaef986884ccad769aee98c918f1c Mon Sep 17 00:00:00 2001 From: Dennis Loose Date: Fri, 13 Dec 2024 14:32:22 +0100 Subject: [PATCH] chore(app-center): remove `listMyVotes` --- .../lib/ratings/ratings_service.dart | 5 --- .../app_center/test/ratings_service_test.dart | 31 ------------------- packages/app_center/test/test_utils.dart | 2 -- 3 files changed, 38 deletions(-) diff --git a/packages/app_center/lib/ratings/ratings_service.dart b/packages/app_center/lib/ratings/ratings_service.dart index e297c00f6..9cd242be5 100644 --- a/packages/app_center/lib/ratings/ratings_service.dart +++ b/packages/app_center/lib/ratings/ratings_service.dart @@ -54,11 +54,6 @@ class RatingsService { await client.delete(_jwt!); } - Future> listMyVotes(String snapFilter) async { - await _ensureValidToken(); - return client.listMyVotes(snapFilter, _jwt!); - } - Future> getSnapVotes(String snapId) async { await _ensureValidToken(); return client.getSnapVotes(snapId, _jwt!); diff --git a/packages/app_center/test/ratings_service_test.dart b/packages/app_center/test/ratings_service_test.dart index 1db0db1e3..b90310a47 100644 --- a/packages/app_center/test/ratings_service_test.dart +++ b/packages/app_center/test/ratings_service_test.dart @@ -106,37 +106,6 @@ void main() { verify(mockClient.delete('jwt')).called(1); }); - test('list my votes', () async { - final mockClient = createMockRatingsClient( - token: 'jwt', - myVotes: [ - Vote( - snapId: 'testsnap', - snapRevision: 1, - voteUp: false, - dateTime: DateTime(1984), - ), - ], - ); - final service = RatingsService(mockClient, id: 'myId'); - - final votes = await service.listMyVotes('testsnap'); - verify(mockClient.authenticate('myId')).called(1); - expect( - votes, - equals( - [ - Vote( - snapId: 'testsnap', - snapRevision: 1, - voteUp: false, - dateTime: DateTime(1984), - ), - ], - ), - ); - }); - test('snap votes', () async { final mockClient = createMockRatingsClient( token: 'jwt', diff --git a/packages/app_center/test/test_utils.dart b/packages/app_center/test/test_utils.dart index 4bdb409dc..1b7a0bea3 100644 --- a/packages/app_center/test/test_utils.dart +++ b/packages/app_center/test/test_utils.dart @@ -316,7 +316,6 @@ MockRatingsService registerMockRatingsService({ MockRatingsClient createMockRatingsClient({ String? token, Rating? rating, - List? myVotes, List? snapVotes, List? chartData, }) { @@ -331,7 +330,6 @@ MockRatingsClient createMockRatingsClient({ ratingsBand: RatingsBand.insufficientVotes, ), ); - when(client.listMyVotes(any, any)).thenAnswer((_) async => myVotes ?? []); when(client.getSnapVotes(any, any)).thenAnswer((_) async => snapVotes ?? []); when(client.getChart(any, any, any)).thenAnswer((_) async => chartData ?? []); return client;