Fix invalid golangci-lint config #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
fix-golangci-config
branch
from
2060c76 to
5c90d3f
Compare
The nolintlint settings must be part of the "linters-settings" list.
Since the nolintlint linter is not enabled in this config, we just
remove its settings here.
Fixes that golangci-lint fails in the CI with:
Failed to run: Error: Command failed: /home/runner/golangci-lint-1.63.4-linux-amd64/golangci-lint config verify
jsonschema: "" does not validate with "/additionalProperties": additional properties 'nolintlint' not allowed
Failed executing command with error: the configuration contains invalid elements
adombeck
force-pushed
the
fix-golangci-config
branch
from
5c90d3f to
3d3881f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nolintlint settings must be part of the "linters-settings" list.
Since the nolintlint linter is not enabled in this config, we just
remove its settings here.
Fixes that golangci-lint fails in the CI with: