Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VADC-904 #134

Merged
merged 9 commits into from
Apr 10, 2024
Merged

VADC-904 #134

merged 9 commits into from
Apr 10, 2024

Conversation

tianj7
Copy link
Contributor

@tianj7 tianj7 commented Apr 8, 2024

https://ctds-planx.atlassian.net/browse/VADC-904

New Features

Add username to workflow api

pieterlukasse
pieterlukasse reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an existing method in the code that already does what you added! Please take a look

pieterlukasse
pieterlukasse reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: use convert_username_label_to_gen3username in parse_details

pieterlukasse
pieterlukasse previously approved these changes Apr 9, 2024
View reviewed changes
@tianj7 tianj7 merged commit c2bdbc1 into master Apr 10, 2024
6 checks passed
@tianj7 tianj7 deleted the feat/vadc-904 branch April 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlukasse pieterlukasse pieterlukasse approved these changes

Assignees
No one assigned
Labels
test-portal-homepageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianj7 @pieterlukasse