Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update temporary directory size limit #156

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

wangfan860
Copy link
Contributor

Improvements

Increased the temporary directory size limit in Argo workflows to better handle resource-intensive operations (e.g., when user defines MAF=0, which will increase the output file size). Changes were applied to:

  • src/argowrapper/argo_workflows_templates/header.yaml
  • src/argowrapper/workflows/argo_workflows/gwas.py
  • workflow_examples/gwas_header.yaml

Copy link
Contributor

@vzpgb vzpgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vzpgb vzpgb requested a review from tianj7 December 5, 2024 17:54
Copy link

github-actions bot commented Dec 5, 2024

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@wangfan860 wangfan860 merged commit 0562c72 into master Dec 5, 2024
10 checks passed
@wangfan860 wangfan860 deleted the temp_directory_size branch December 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants