wip: add validation TODOs

pieterlukasse · pieterlukasse · commit 9ac89356b968 · 2024-01-23T19:25:37.000+01:00
diff --git a/controllers/cohortdefinition.go b/controllers/cohortdefinition.go
@@ -18,6 +18,7 @@ func NewCohortDefinitionController(cohortDefinitionModel models.CohortDefinition
 }
 
 func (u CohortDefinitionController) RetriveById(c *gin.Context) {
+	// TODO - add teamproject validation - check if user has the necessary atlas and arborist permissions
 	cohortDefinitionId := c.Param("id")
 
 	if cohortDefinitionId != "" {
@@ -44,6 +45,7 @@ func (u CohortDefinitionController) RetriveStatsBySourceIdAndTeamProject(c *gin.
 		c.Abort()
 		return
 	}
+	// TODO - validate teamproject against arborist
 	if err1 == nil {
 		cohortDefinitionsAndStats, err := u.cohortDefinitionModel.GetAllCohortDefinitionsAndStatsOrderBySizeDesc(sourceId, teamProject)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ func NewCohortDefinitionController(cohortDefinitionModel models.CohortDefinition`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`func (u CohortDefinitionController) RetriveById(c *gin.Context) {`
	`21`	`+ // TODO - add teamproject validation - check if user has the necessary atlas and arborist permissions`
`21`	`22`	`cohortDefinitionId := c.Param("id")`
`22`	`23`
`23`	`24`	`if cohortDefinitionId != "" {`
`@@ -44,6 +45,7 @@ func (u CohortDefinitionController) RetriveStatsBySourceIdAndTeamProject(c *gin.`
`44`	`45`	`c.Abort()`
`45`	`46`	`return`
`46`	`47`	`}`
	`48`	`+ // TODO - validate teamproject against arborist`
`47`	`49`	`if err1 == nil {`
`48`	`50`	`cohortDefinitionsAndStats, err := u.cohortDefinitionModel.GetAllCohortDefinitionsAndStatsOrderBySizeDesc(sourceId, teamProject)`
`49`	`51`	`if err != nil {`