Skip to content

Commit af0320d

Browse files
committed
fix: fix breakdown query so it checks on the breakdown concept values
1 parent a1e9790 commit af0320d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

models/concept.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@ func (h Concept) RetrieveBreakdownStatsBySourceIdAndCohortIdAndConceptDefsPlusCo
153153
query, finalObservationTableAlias := QueryFilterByConceptDefsPlusCohortPairsHelper(query, sourceId, cohortDefinitionId, filterConceptDefsAndCohortPairs, omopDataSource, resultsDataSource, finalSetAlias)
154154
// count persons, grouping by concept value:
155155
if finalObservationTableAlias != "" {
156-
query = query.Select(finalObservationTableAlias + ".value_as_concept_id, count(distinct(" + finalObservationTableAlias + ".person_id)) as npersons_in_cohort_with_value").
156+
query = query.Select(finalObservationTableAlias+".value_as_concept_id, count(distinct("+finalObservationTableAlias+".person_id)) as npersons_in_cohort_with_value").
157+
Where(finalObservationTableAlias+".observation_concept_id = ?", breakdownConceptId).
158+
Where(GetConceptValueNotNullCheckBasedOnConceptType(finalObservationTableAlias, sourceId, breakdownConceptId)).
157159
Group(finalObservationTableAlias + ".value_as_concept_id")
158160
} else {
159161
query = query.Select("observation.value_as_concept_id, count(distinct(observation.person_id)) as npersons_in_cohort_with_value").

0 commit comments

Comments
 (0)