Feat: add filter and transformation support to breakdown / attrition endpoint #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please find the detailed integration test report here Please find the ci env pod logs here |
pieterlukasse
changed the title
pieterlukasse
force-pushed
the
feat/add_filter_and_transformation_to_remaining_endpoints
branch
from
59fb8c8 to
4826d19
Compare
|
Please find the ci env pod logs here |
pieterlukasse
force-pushed
the
feat/support_filters_and_transformation
branch
from
0ac4088 to
859816c
Compare
pieterlukasse
force-pushed
the
feat/add_filter_and_transformation_to_remaining_endpoints
branch
from
e7413ab to
2bd4881
Compare
Please find the detailed integration test report here Please find the ci env pod logs here |
Base automatically changed from
feat/support_filters_and_transformation
to
master
February 11, 2025 18:10
pieterlukasse
changed the base branch from
master
to
feat/support_filters_and_transformation
Base automatically changed from
feat/support_filters_and_transformation
to
feat/filters_and_transformation_main
February 11, 2025 18:30
pieterlukasse
force-pushed
the
feat/add_filter_and_transformation_to_remaining_endpoints
branch
from
2bd4881 to
1fd5ac9
Compare
…endpoint Also: - feat: update RetrieveStatsForCohortIdAndConceptId and remove deprecated method - feat: refactor RetrieveCohortOverlapStats and fix breakdown stats method ...and fix model tests - feat: comment on a comment ...see also #5 (comment) - feat: refactor RetrieveDataBySourceIdAndCohortIdAndVariables ... and deprecate model method in favor of the histogram one that retrieves the same data but is already refactored. - feat: remove deprecated breakdown stats method
pieterlukasse
force-pushed
the
feat/add_filter_and_transformation_to_remaining_endpoints
branch
from
1fd5ac9 to
2c9901b
Compare
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
tianj7
reviewed
Feb 28, 2025
tianj7
reviewed
Feb 28, 2025
Please find the detailed integration test report here Please find the ci env pod logs here |
pieterlukasse
merged commit 326d2ff
into
feat/filters_and_transformation_main
9 of 11 checks passed
pieterlukasse
deleted the
feat/add_filter_and_transformation_to_remaining_endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1642
New Features
Breaking changes
/cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortid/by-concept-id/:conceptidis now adjusted to/cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortidand the concept to get stats on should be the last variable in the POST request body