Feat: add support for filters and transformation #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add new support for filters and transformation arguments in histogram endpoint * fix: fix the naming for concept lists ...from ids to definitions (defs) and add some parsing for the new filter entries in request body * feat: working histogram endpoint POC for using tmp table for transformations * feat: added first log transformation * feat: added z-score transformation * feat: add tempttablecache to include cleanup of oldest / least accessed item * tmp: temporarily disable strict validation until frontend is fixed * feat: add new ToSQL wrapper method * feat: remove histogramConceptId from histogram endpoint ...and expect it as part of the variables instead * fix: make sure only postgresql and sqlserver are accepted for now * fix: naming improvements and extra unit tests * fix: improve coverage of parsing.go * feat: improve coverage of TempTableCache * feat: improve coverage of TableExists
…endpoint (#126) * feat: add filter and transformation support to breakdown / attrition endpoint Also: - feat: update RetrieveStatsForCohortIdAndConceptId and remove deprecated method - feat: refactor RetrieveCohortOverlapStats and fix breakdown stats method ...and fix model tests - feat: comment on a comment ...see also #5 (comment) - feat: refactor RetrieveDataBySourceIdAndCohortIdAndVariables ... and deprecate model method in favor of the histogram one that retrieves the same data but is already refactored. - feat: remove deprecated breakdown stats method * fix: restore variable type validation * feat: remove QueryFilterByConceptIdsHelper deprecated method * fix: fix breakdown query so it checks on the breakdown concept values * fix: fix breakdown query * fix: better naming and more tests covering filter/transformation
Please find the detailed integration test report here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1642,
https://ctds-planx.atlassian.net/browse/VADC-1585,
https://ctds-planx.atlassian.net/browse/VADC-1586
Combines #128 and #126 in a single PR to
master.New Features
Deployment changes
Breaking changes
/cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortid/by-concept-id/:conceptidis now adjusted to/cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortidand the concept to get stats on should be the last variable in the POST request body/histogram/by-source-id/:sourceid/by-cohort-definition-id/:cohortid/by-histogram-concept-id/:histogramidis now adjusted to/histogram/by-source-id/:sourceid/by-cohort-definition-id/:cohortidand the concept to get histogram on should be the last variable in the POST request body