[WIP] Feat/nextflow_integration_tests #157
Draft
+907
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/info` endpoints (Untested)
|
Please find the ci env pod logs here |
| @@ -0,0 +1,133 @@ | |||
| from typing import Dict, Tuple | |||
There was a problem hiding this comment.
could you rename the file gen3workflow instead of gen3workflows
There was a problem hiding this comment.
I will rename the file once all the other review comments in this file are addressed and resolved. Since renaming kind of stirs things up letting git assume that the file with all these comments is deleted.
Please find the detailed integration test report here Please find the ci env pod logs here |
…n remove `skipif` in methods
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
| "Authorization": f"bearer {self._get_access_token(user)}", | ||
| } | ||
| if user | ||
| else {} |
There was a problem hiding this comment.
Suggested change
| else {} | |
| else {"Content-Type": "application/json"} |
| user=self.valid_user, | ||
| expected_status=200, | ||
| ) | ||
| assert ( | ||
| isinstance(response_contents, list) and len(response_contents) > 0 | ||
| ), "Expected the function to return a list of at least one item" | ||
| ), "Expected the function to return a list of at least one item but received: {response_contents}" |
There was a problem hiding this comment.
Suggested change
| ), "Expected the function to return a list of at least one item but received: {response_contents}" | |
| ), f"Expected the function to return a list of at least one item but received: {response_contents}" |
| ) | ||
|
|
||
| def create_tes_task( | ||
| self, request_body: dict, user: str = "main_account", expected_status=200 |
There was a problem hiding this comment.
the request_body isn't used
| expected_status=401, | ||
| ) | ||
|
|
||
| def test_happy_path_create_tes_tasks(self): |
There was a problem hiding this comment.
Could we check that the created task completes successfully, and that the outputs are available and correct?
| expected_status=401, | ||
| ) | ||
|
|
||
| def test_happy_path_create_tes_tasks(self): |
There was a problem hiding this comment.
Could we merge test_happy_path_create_tes_tasks, test_happy_path_list_tes_tasks and test_happy_path_get_tes_tasks into 1 so we don't create multiple TES tasks that the backend will be busy running (it will slow down any test that waits for a task to complete)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: MIDRC-860
New Features
Dependency updates
nextflowandboto3as poetry dependencies