Add --timeout-second and retry to callVariant #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a transcript with 375 SNV/Indels and can not finish in hours. The limiting step is calling mislceaved peptides from the PCG, after cleavage. Setting a global
max_variants_per_node
doesn't make a lot sense to me, so I implemented a timeout function. So for each transcript, if it can't be finished in certain time, it will stop and retry with a lowermax_variants_per_node
(andadditional_variants_per_misc
).The
--timeout-seconds
is added to callVariant and defaults to 30 minutes.The
--max-variants-per-node
and--additional-variants-per-misc
can accept multiple values now, and they will be used as the "retry strategy". And if we run out of the--max-variants-per-node
values, it will continue retry with the previous value minus 1 until 0 and raise an error. For example, with--max-variants-per-node 7 5
, the retries will be 7 -> 5 -> 4 -> 3 -> 2 -> 1 -> error (which should never happen).--additional-variants-per-misc
is slightly different. If we run out of values, 0 will be used. So by default it will be 2 -> 0Closes #...
Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.CHANGELOG.md
under the next release version or unreleased, and updated the date.