Skip to content

Commit 94c24a0

Browse files
committed
v2.1.6 fix: fix readOnly props issue. (#152) 42d50b3
1 parent a69f8f6 commit 94c24a0

16 files changed

+96
-76
lines changed

asset-manifest.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
22
"files": {
33
"main.css": "/react-textarea-code-editor/static/css/main.9c5e4e20.css",
4-
"main.js": "/react-textarea-code-editor/static/js/main.1f3153b9.js",
4+
"main.js": "/react-textarea-code-editor/static/js/main.e1f38675.js",
55
"code-example-vendor.js": "/react-textarea-code-editor/static/js/code-example-vendor.0a8466ed.chunk.js",
66
"refractor-vendor.js": "/react-textarea-code-editor/static/js/refractor-vendor.6c222c0e.js",
77
"react-vendor.js": "/react-textarea-code-editor/static/js/react-vendor.17a134cf.js",
88
"index.html": "/react-textarea-code-editor/index.html",
99
"main.9c5e4e20.css.map": "/react-textarea-code-editor/static/css/main.9c5e4e20.css.map",
10-
"main.1f3153b9.js.map": "/react-textarea-code-editor/static/js/main.1f3153b9.js.map",
10+
"main.e1f38675.js.map": "/react-textarea-code-editor/static/js/main.e1f38675.js.map",
1111
"code-example-vendor.0a8466ed.chunk.js.map": "/react-textarea-code-editor/static/js/code-example-vendor.0a8466ed.chunk.js.map",
1212
"refractor-vendor.6c222c0e.js.map": "/react-textarea-code-editor/static/js/refractor-vendor.6c222c0e.js.map",
1313
"react-vendor.17a134cf.js.map": "/react-textarea-code-editor/static/js/react-vendor.17a134cf.js.map"
@@ -16,6 +16,6 @@
1616
"static/js/refractor-vendor.6c222c0e.js",
1717
"static/js/react-vendor.17a134cf.js",
1818
"static/css/main.9c5e4e20.css",
19-
"static/js/main.1f3153b9.js"
19+
"static/js/main.e1f38675.js"
2020
]
2121
}

coverage/badges.svg

Lines changed: 4 additions & 4 deletions
Loading

coverage/coverage-summary.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
{"total": {"lines":{"total":116,"covered":113,"skipped":0,"pct":97.41},"statements":{"total":119,"covered":116,"skipped":0,"pct":97.47},"functions":{"total":26,"covered":24,"skipped":0,"pct":92.3},"branches":{"total":82,"covered":75,"skipped":0,"pct":91.46},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":"Unknown"}}
1+
{"total": {"lines":{"total":119,"covered":116,"skipped":0,"pct":97.47},"statements":{"total":123,"covered":119,"skipped":0,"pct":96.74},"functions":{"total":26,"covered":24,"skipped":0,"pct":92.3},"branches":{"total":84,"covered":76,"skipped":0,"pct":90.47},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":"Unknown"}}
22
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/SelectionText.ts": {"lines":{"total":49,"covered":49,"skipped":0,"pct":100},"functions":{"total":12,"covered":12,"skipped":0,"pct":100},"statements":{"total":50,"covered":50,"skipped":0,"pct":100},"branches":{"total":24,"covered":20,"skipped":0,"pct":83.33}}
3-
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/index.tsx": {"lines":{"total":16,"covered":16,"skipped":0,"pct":100},"functions":{"total":7,"covered":7,"skipped":0,"pct":100},"statements":{"total":18,"covered":18,"skipped":0,"pct":100},"branches":{"total":27,"covered":26,"skipped":0,"pct":96.29}}
3+
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/index.tsx": {"lines":{"total":19,"covered":19,"skipped":0,"pct":100},"functions":{"total":7,"covered":7,"skipped":0,"pct":100},"statements":{"total":22,"covered":21,"skipped":0,"pct":95.45},"branches":{"total":29,"covered":27,"skipped":0,"pct":93.1}}
44
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/shortcuts.ts": {"lines":{"total":40,"covered":39,"skipped":0,"pct":97.5},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":40,"covered":39,"skipped":0,"pct":97.5},"branches":{"total":30,"covered":28,"skipped":0,"pct":93.33}}
55
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/styles.ts": {"lines":{"total":3,"covered":3,"skipped":0,"pct":100},"functions":{"total":0,"covered":0,"skipped":0,"pct":100},"statements":{"total":3,"covered":3,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
66
,"/home/runner/work/react-textarea-code-editor/react-textarea-code-editor/src/utils.ts": {"lines":{"total":8,"covered":6,"skipped":0,"pct":75},"functions":{"total":6,"covered":4,"skipped":0,"pct":66.66},"statements":{"total":8,"covered":6,"skipped":0,"pct":75},"branches":{"total":1,"covered":1,"skipped":0,"pct":100}}

coverage/lcov-report/SelectionText.ts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ <h1><a href="index.html">All files</a> SelectionText.ts</h1>
358358
<div class='footer quiet pad2 space-top1 center small'>
359359
Code coverage generated by
360360
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
361-
at 2023-06-11T09:41:09.277Z
361+
at 2023-06-23T12:45:05.200Z
362362
</div>
363363
<script src="prettify.js"></script>
364364
<script>

coverage/lcov-report/index.html

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ <h1>All files</h1>
2323
<div class='clearfix'>
2424

2525
<div class='fl pad1y space-right2'>
26-
<span class="strong">97.47% </span>
26+
<span class="strong">96.74% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>116/119</span>
28+
<span class='fraction'>119/123</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">91.46% </span>
33+
<span class="strong">90.47% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>75/82</span>
35+
<span class='fraction'>76/84</span>
3636
</div>
3737

3838

@@ -44,9 +44,9 @@ <h1>All files</h1>
4444

4545

4646
<div class='fl pad1y space-right2'>
47-
<span class="strong">97.41% </span>
47+
<span class="strong">97.47% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>113/116</span>
49+
<span class='fraction'>116/119</span>
5050
</div>
5151

5252

@@ -95,17 +95,17 @@ <h1>All files</h1>
9595

9696
<tr>
9797
<td class="file high" data-value="index.tsx"><a href="index.tsx.html">index.tsx</a></td>
98-
<td data-value="100" class="pic high">
99-
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
98+
<td data-value="95.45" class="pic high">
99+
<div class="chart"><div class="cover-fill" style="width: 95%"></div><div class="cover-empty" style="width: 5%"></div></div>
100100
</td>
101-
<td data-value="100" class="pct high">100%</td>
102-
<td data-value="18" class="abs high">18/18</td>
103-
<td data-value="96.29" class="pct high">96.29%</td>
104-
<td data-value="27" class="abs high">26/27</td>
101+
<td data-value="95.45" class="pct high">95.45%</td>
102+
<td data-value="22" class="abs high">21/22</td>
103+
<td data-value="93.1" class="pct high">93.1%</td>
104+
<td data-value="29" class="abs high">27/29</td>
105105
<td data-value="100" class="pct high">100%</td>
106106
<td data-value="7" class="abs high">7/7</td>
107107
<td data-value="100" class="pct high">100%</td>
108-
<td data-value="16" class="abs high">16/16</td>
108+
<td data-value="19" class="abs high">19/19</td>
109109
</tr>
110110

111111
<tr>
@@ -161,7 +161,7 @@ <h1>All files</h1>
161161
<div class='footer quiet pad2 space-top1 center small'>
162162
Code coverage generated by
163163
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
164-
at 2023-06-11T09:41:09.277Z
164+
at 2023-06-23T12:45:05.200Z
165165
</div>
166166
<script src="prettify.js"></script>
167167
<script>

coverage/lcov-report/index.tsx.html

Lines changed: 35 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
2323
<div class='clearfix'>
2424

2525
<div class='fl pad1y space-right2'>
26-
<span class="strong">100% </span>
26+
<span class="strong">95.45% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>18/18</span>
28+
<span class='fraction'>21/22</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">96.29% </span>
33+
<span class="strong">93.1% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>26/27</span>
35+
<span class='fraction'>27/29</span>
3636
</div>
3737

3838

@@ -46,7 +46,7 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
4646
<div class='fl pad1y space-right2'>
4747
<span class="strong">100% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>16/16</span>
49+
<span class='fraction'>19/19</span>
5050
</div>
5151

5252

@@ -188,7 +188,12 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
188188
<a name='L123'></a><a href='#L123'>123</a>
189189
<a name='L124'></a><a href='#L124'>124</a>
190190
<a name='L125'></a><a href='#L125'>125</a>
191-
<a name='L126'></a><a href='#L126'>126</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
191+
<a name='L126'></a><a href='#L126'>126</a>
192+
<a name='L127'></a><a href='#L127'>127</a>
193+
<a name='L128'></a><a href='#L128'>128</a>
194+
<a name='L129'></a><a href='#L129'>129</a>
195+
<a name='L130'></a><a href='#L130'>130</a>
196+
<a name='L131'></a><a href='#L131'>131</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
192197
<span class="cline-any cline-neutral">&nbsp;</span>
193198
<span class="cline-any cline-neutral">&nbsp;</span>
194199
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -276,15 +281,22 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
276281
<span class="cline-any cline-neutral">&nbsp;</span>
277282
<span class="cline-any cline-neutral">&nbsp;</span>
278283
<span class="cline-any cline-yes">53x</span>
284+
<span class="cline-any cline-yes">18x</span>
285+
<span class="cline-any cline-yes">18x</span>
279286
<span class="cline-any cline-neutral">&nbsp;</span>
280287
<span class="cline-any cline-neutral">&nbsp;</span>
288+
<span class="cline-any cline-yes">53x</span>
289+
<span class="cline-any cline-yes">16x</span>
290+
<span class="cline-any cline-yes">16x</span>
291+
<span class="cline-any cline-yes">16x</span>
281292
<span class="cline-any cline-neutral">&nbsp;</span>
282293
<span class="cline-any cline-neutral">&nbsp;</span>
283294
<span class="cline-any cline-neutral">&nbsp;</span>
295+
<span class="cline-any cline-yes">53x</span>
296+
<span class="cline-any cline-neutral">&nbsp;</span>
297+
<span class="cline-any cline-neutral">&nbsp;</span>
284298
<span class="cline-any cline-neutral">&nbsp;</span>
285299
<span class="cline-any cline-neutral">&nbsp;</span>
286-
<span class="cline-any cline-yes">16x</span>
287-
<span class="cline-any cline-yes">16x</span>
288300
<span class="cline-any cline-neutral">&nbsp;</span>
289301
<span class="cline-any cline-neutral">&nbsp;</span>
290302
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -295,8 +307,6 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
295307
<span class="cline-any cline-neutral">&nbsp;</span>
296308
<span class="cline-any cline-neutral">&nbsp;</span>
297309
<span class="cline-any cline-neutral">&nbsp;</span>
298-
<span class="cline-any cline-yes">18x</span>
299-
<span class="cline-any cline-yes">18x</span>
300310
<span class="cline-any cline-neutral">&nbsp;</span>
301311
<span class="cline-any cline-neutral">&nbsp;</span>
302312
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -399,6 +409,18 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
399409
// eslint-disable-next-line react-hooks/exhaustive-deps
400410
[prefixCls, language, htmlStr],
401411
);
412+
&nbsp;
413+
const change = (evn: React.ChangeEvent&lt;HTMLTextAreaElement&gt;) =&gt; {
414+
setValue(evn.target.value);
415+
onChange &amp;&amp; onChange(evn);
416+
};
417+
&nbsp;
418+
const keyDown = (evn: React.KeyboardEvent&lt;HTMLTextAreaElement&gt;) =&gt; {
419+
<span class="missing-if-branch" title="if path not taken" >I</span>if (other.readOnly) <span class="cstat-no" title="statement not covered" >return;</span>
420+
<span class="missing-if-branch" title="else path not taken" >E</span>if (!other.onKeyDown || other.onKeyDown(evn) !== false) {
421+
shortcuts(evn);
422+
}
423+
};
402424
&nbsp;
403425
const textareaProps: React.TextareaHTMLAttributes&lt;HTMLTextAreaElement&gt; = {
404426
autoComplete: 'off',
@@ -407,22 +429,15 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
407429
autoCapitalize: 'off',
408430
...other,
409431
placeholder,
410-
onKeyDown: (evn) =&gt; {
411-
<span class="missing-if-branch" title="else path not taken" >E</span>if (!other.onKeyDown || other.onKeyDown(evn) !== false) {
412-
shortcuts(evn);
413-
}
414-
},
432+
onKeyDown: keyDown,
415433
style: {
416434
...styles.editor,
417435
...styles.textarea,
418436
...contentStyle,
419437
minHeight,
420438
...(placeholder &amp;&amp; !value ? { WebkitTextFillColor: 'inherit' } : {}),
421439
},
422-
onChange: (evn) =&gt; {
423-
setValue(evn.target.value);
424-
onChange &amp;&amp; onChange(evn);
425-
},
440+
onChange: change,
426441
className: `${prefixCls}-text`,
427442
value: value,
428443
};
@@ -445,7 +460,7 @@ <h1><a href="index.html">All files</a> index.tsx</h1>
445460
<div class='footer quiet pad2 space-top1 center small'>
446461
Code coverage generated by
447462
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
448-
at 2023-06-11T09:41:09.277Z
463+
at 2023-06-23T12:45:05.200Z
449464
</div>
450465
<script src="prettify.js"></script>
451466
<script>

coverage/lcov-report/shortcuts.ts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ <h1><a href="index.html">All files</a> shortcuts.ts</h1>
262262
<div class='footer quiet pad2 space-top1 center small'>
263263
Code coverage generated by
264264
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
265-
at 2023-06-11T09:41:09.277Z
265+
at 2023-06-23T12:45:05.200Z
266266
</div>
267267
<script src="prettify.js"></script>
268268
<script>

coverage/lcov-report/styles.ts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ <h1><a href="index.html">All files</a> styles.ts</h1>
211211
<div class='footer quiet pad2 space-top1 center small'>
212212
Code coverage generated by
213213
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
214-
at 2023-06-11T09:41:09.277Z
214+
at 2023-06-23T12:45:05.200Z
215215
</div>
216216
<script src="prettify.js"></script>
217217
<script>

coverage/lcov-report/utils.ts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ <h1><a href="index.html">All files</a> utils.ts</h1>
160160
<div class='footer quiet pad2 space-top1 center small'>
161161
Code coverage generated by
162162
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
163-
at 2023-06-11T09:41:09.277Z
163+
at 2023-06-23T12:45:05.200Z
164164
</div>
165165
<script src="prettify.js"></script>
166166
<script>

coverage/lcov.info

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,17 @@ FN:53,(anonymous_1)
111111
FN:55,(anonymous_2)
112112
FN:65,(anonymous_3)
113113
FN:75,(anonymous_4)
114-
FN:95,(anonymous_5)
115-
FN:107,(anonymous_6)
114+
FN:88,(anonymous_5)
115+
FN:93,(anonymous_6)
116116
FNF:7
117117
FNH:7
118118
FNDA:54,(anonymous_0)
119119
FNDA:20,(anonymous_1)
120120
FNDA:1,(anonymous_2)
121121
FNDA:38,(anonymous_3)
122122
FNDA:38,(anonymous_4)
123-
FNDA:16,(anonymous_5)
124-
FNDA:18,(anonymous_6)
123+
FNDA:18,(anonymous_5)
124+
FNDA:16,(anonymous_6)
125125
DA:50,54
126126
DA:52,53
127127
DA:53,53
@@ -133,13 +133,16 @@ DA:66,38
133133
DA:74,53
134134
DA:76,38
135135
DA:88,53
136+
DA:89,18
137+
DA:90,18
138+
DA:93,53
139+
DA:94,16
140+
DA:95,16
136141
DA:96,16
137-
DA:97,16
138-
DA:108,18
139-
DA:109,18
140-
DA:115,53
141-
LF:16
142-
LH:16
142+
DA:100,53
143+
DA:120,53
144+
LF:19
145+
LH:19
143146
BRDA:38,0,0,53
144147
BRDA:40,1,0,53
145148
BRDA:41,2,0,53
@@ -155,20 +158,22 @@ BRDA:68,7,0,38
155158
BRDA:68,7,1,2
156159
BRDA:78,8,0,37
157160
BRDA:78,8,1,1
158-
BRDA:96,9,0,16
159-
BRDA:96,9,1,0
160-
BRDA:96,10,0,16
161-
BRDA:96,10,1,3
162-
BRDA:105,11,0,2
163-
BRDA:105,11,1,51
164-
BRDA:105,12,0,53
165-
BRDA:105,12,1,7
166-
BRDA:109,13,0,18
167-
BRDA:109,13,1,1
168-
BRDA:118,14,0,53
169-
BRDA:118,14,1,53
170-
BRF:27
171-
BRH:26
161+
BRDA:90,9,0,18
162+
BRDA:90,9,1,1
163+
BRDA:94,10,0,0
164+
BRDA:94,10,1,16
165+
BRDA:95,11,0,16
166+
BRDA:95,11,1,0
167+
BRDA:95,12,0,16
168+
BRDA:95,12,1,3
169+
BRDA:113,13,0,2
170+
BRDA:113,13,1,51
171+
BRDA:113,14,0,53
172+
BRDA:113,14,1,7
173+
BRDA:123,15,0,53
174+
BRDA:123,15,1,53
175+
BRF:29
176+
BRH:27
172177
end_of_record
173178
TN:
174179
SF:src/shortcuts.ts

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!doctype html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><meta name="description" content="A simple code editor with syntax highlighting. This library aims to provide a simple code editor with syntax highlighting support without any of the extra features, perfect for simple embeds and forms where users can submit code."/><meta name="keywords" content="react,component,textarea,js,css,html,preview,editor"/><link rel="shortcut icon" href="/react-textarea-code-editor/favicon.ico"><title>React Textarea Code Editor - A simple code editor with syntax highlighting.</title><script defer="defer" src="./static/js/refractor-vendor.6c222c0e.js"></script><script defer="defer" src="./static/js/react-vendor.17a134cf.js"></script><script defer="defer" src="./static/js/main.1f3153b9.js"></script><link href="./static/css/main.9c5e4e20.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
1+
<!doctype html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><meta name="description" content="A simple code editor with syntax highlighting. This library aims to provide a simple code editor with syntax highlighting support without any of the extra features, perfect for simple embeds and forms where users can submit code."/><meta name="keywords" content="react,component,textarea,js,css,html,preview,editor"/><link rel="shortcut icon" href="/react-textarea-code-editor/favicon.ico"><title>React Textarea Code Editor - A simple code editor with syntax highlighting.</title><script defer="defer" src="./static/js/refractor-vendor.6c222c0e.js"></script><script defer="defer" src="./static/js/react-vendor.17a134cf.js"></script><script defer="defer" src="./static/js/main.e1f38675.js"></script><link href="./static/css/main.9c5e4e20.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

static/js/main.1f3153b9.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

static/js/main.1f3153b9.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

static/js/main.e1f38675.js

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static/js/main.e1f38675.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)