Skip to content

Initialise ICAv2 Data Copy Manager #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

alexiswl
Copy link
Member

Centralised service for copying data around with ICAv2 Jobs, uses taskTokens for 'synced' events (inside AWS Step Functions).

For example an event might look like

{
  "EventBusName": "OrcaBusMain",
  "Source": "Whatever",
  "DetailType": "ICAv2DataCopySync",
  "Detail": {
    "payload": {
      "sourceUriList": [
        "icav2://project-id-or-name/path-to-data.txt",
        "icav2://project-id-or-name/path-to-folder/"
      ],
      "destinationUri": "icav2://project-id-or-name/path-to-destination/"
    },
    "taskToken": "your-task-token"
  }
}

Or

{
  "EventBusName": "OrcaBusMain",
  "Source": "Whatever",
  "DetailType": "ICAv2DataCopy",
  "Detail": {
    "payload": {
      "sourceUriList": [
        "icav2://project-id-or-name/path-to-data.txt",
        "icav2://project-id-or-name/path-to-folder/"
      ],
      "destinationUri": "icav2://project-id-or-name/path-to-destination/"
    }
  }
}

One can generate the Detail from the source with the following AWS StepFunctions Code

{
  "QueryLanguage": "JSONata",
  ...
  "States": {
    "Copy Files to Destination": {
      "Type": "Task",
      "Resource": "arn:aws:states:::events:putEvents.waitForTaskToken",
      "Arguments": {
        "Entries": [
          {
            "Detail": "{% $merge(\n  [\n    {\n      \"taskToken\": $states.context.Task.Token\n    }, \n    $copy_event_detail\n  ]\n) %}",
            "DetailType": "ICAv2DataCopy",
            "EventBusName": "OrcaBusMain",
            "Source": "Whatever"
          }
        ]
      },
      "Next": ...
    }
  }
}

@alexiswl alexiswl added the feature New feature label Dec 19, 2024
@alexiswl alexiswl self-assigned this Dec 19, 2024
@victorskl
Copy link
Member

Please on hold merge this PR until 0.3.0 release wrap up.

@victorskl victorskl removed the on hold label Jan 3, 2025
@victorskl
Copy link
Member

Depends on task token that implemented in #789

@alexiswl
Copy link
Member Author

Depends on task token that implemented in #789

Ah not quite, this one would have its own task token management system, #789 was for workflow events specifically

@victorskl
Copy link
Member

Similarly to this PR as well. ditto related conclusion comment here.

Please set PR Ready; once finalised. Thanks.

@alexiswl alexiswl force-pushed the feature/icav2-data-copy-service branch from 7e51bdb to 171e397 Compare March 18, 2025 07:30
@alexiswl
Copy link
Member Author

This one is already ready to be reviewed now

@alexiswl alexiswl marked this pull request as ready for review March 18, 2025 08:55
@alexiswl alexiswl force-pushed the feature/icav2-data-copy-service branch 2 times, most recently from 3d88ee1 to 38dc307 Compare April 1, 2025 10:35
@victorskl victorskl linked an issue Apr 2, 2025 that may be closed by this pull request
@alexiswl alexiswl force-pushed the feature/icav2-data-copy-service branch from 38dc307 to 2b6ee7c Compare April 17, 2025 02:51
@alexiswl alexiswl added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 676b65b Apr 17, 2025
4 of 5 checks passed
@alexiswl alexiswl deleted the feature/icav2-data-copy-service branch April 17, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in data-sharing service
3 participants