Update fastq unarchiver step function to chunk fastq ids to prevent lambda timeouts #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead get instrument run ids for every batch of 10 instrument run ids, use jsonata to merge at the end
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the IAM policy statements used in the FastqUnarchivingManagerStack to better separate permissions and prevent lambda timeouts.
- Removed extra actions from the initial IAM policy statement and added a new statement for the redrive execution action.
- Updated the NagSuppressions call to include an additional resource ('distributedMapPolicy').
Files not reviewed (1)
- lib/workload/stateless/stacks/fastq-unarchiving/app/step_functions_templates/run_s3_steps_copy_sfns_sfn_template.asl.json: Language not supported
Comments suppressed due to low confidence (2)
lib/workload/stateless/stacks/fastq-unarchiving/deploy/index.ts:377
- Ensure that the removal of 'states:DescribeExecution' and 'states:StopExecution' from this policy statement is intentional and that any functionality relying on those permissions is addressed elsewhere.
actions: ['states:StartExecution'],
lib/workload/stateless/stacks/fastq-unarchiving/deploy/index.ts:409
- Verify that 'distributedMapPolicy' is correctly defined and intended for inclusion in the NagSuppressions call to avoid potential runtime issues.
[runUnarchivingStateMachine, distributedMapPolicy],
alexiswl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Chunk' the get instrument run id list to prevent lambda timeouts
Instead get instrument run ids for every batch of 10 instrument run ids, use jsonata to merge the chunks at the end of the map