Skip to content

Chore: Deprecate workflow manager and sequence run manager stacks #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Chore: Deprecate workflow manager and sequence run manager stacks #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,10 @@ test-stateful-app-suite:
@(cd lib/workload/stateful/stacks/token-service && $(MAKE) test)

test-stateless-app-suite:
@(cd lib/workload/stateless/stacks/sequence-run-manager && $(MAKE) test)
@(cd lib/workload/stateless/stacks/metadata-manager && $(MAKE) test)
@(cd lib/workload/stateless/stacks/filemanager && $(MAKE) test)
@(cd lib/workload/stateless/stacks/fmannotator && $(MAKE) test)
@(cd lib/workload/stateless/stacks/bclconvert-manager && $(MAKE) test)
@(cd lib/workload/stateless/stacks/workflow-manager && $(MAKE) test)

# The default outer `test` target run all test in this repo
test: test-stateful-iac test-stateless-iac test-stateful-app-suite test-stateless-app-suite
Expand Down
36 changes: 14 additions & 22 deletions lib/workload/stateless/statelessStackCollectionClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
import { Construct } from 'constructs';
import { Stack, Environment, StackProps } from 'aws-cdk-lib';

import { FilemanagerProps, Filemanager } from './stacks/filemanager/deploy/stack';

import {
MetadataManagerStack,
MetadataManagerStackProps,
} from './stacks/metadata-manager/deploy/stack';
import {
SequenceRunManagerStack,
SequenceRunManagerStackProps,
} from './stacks/sequence-run-manager/deploy/stack';
import {
BsshIcav2FastqCopyManagerStack,
BsshIcav2FastqCopyManagerStackProps,
Expand All @@ -28,10 +22,6 @@ import {
BclConvertManagerStack,
BclConvertManagerStackProps,
} from './stacks/bclconvert-manager/deploy/stack';
import {
WorkflowManagerStack,
WorkflowManagerStackProps,
} from './stacks/workflow-manager/deploy/stack';
import { GlueStack, GlueStackProps } from './stacks/stacky-mcstackface/glue-constructs';
import {
WgtsQcIcav2PipelineManagerStack,
Expand Down Expand Up @@ -97,7 +87,6 @@ import { FastqGlueStack, FastqGlueStackProps } from './stacks/fastq-glue/deploy'

export interface StatelessStackCollectionProps {
metadataManagerStackProps: MetadataManagerStackProps;
sequenceRunManagerStackProps: SequenceRunManagerStackProps;
fileManagerStackProps: FilemanagerProps;
bsshIcav2FastqCopyManagerStackProps: BsshIcav2FastqCopyManagerStackProps;
bclconvertInteropQcIcav2PipelineManagerStackProps: BclconvertInteropQcIcav2PipelineManagerStackProps;
Expand All @@ -115,7 +104,6 @@ export interface StatelessStackCollectionProps {
eventSchemaStackProps: SchemaStackProps;
dataSchemaStackProps: SchemaStackProps;
bclConvertManagerStackProps: BclConvertManagerStackProps;
workflowManagerStackProps: WorkflowManagerStackProps;
stackyMcStackFaceProps: GlueStackProps;
fmAnnotatorProps: FMAnnotatorConfigurableProps;
dataMigrateProps: DataMigrateStackProps;
Expand All @@ -134,7 +122,6 @@ export class StatelessStackCollection {
// You could add more stack here and initiate it at the constructor. See example below for reference
readonly fileManagerStack: Stack;
readonly metadataManagerStack: Stack;
readonly sequenceRunManagerStack: Stack;
readonly bsshIcav2FastqCopyManagerStack: Stack;
readonly bclconvertInteropQcIcav2PipelineManagerStack: Stack;
readonly cttsov2Icav2PipelineManagerStack: Stack;
Expand All @@ -151,7 +138,6 @@ export class StatelessStackCollection {
readonly eventSchemaStack: Stack;
readonly dataSchemaStack: Stack;
readonly bclConvertManagerStack: Stack;
readonly workflowManagerStack: Stack;
readonly stackyMcStackFaceStack: Stack;
readonly fmAnnotator: Stack;
readonly dataMigrate: Stack;
Expand Down Expand Up @@ -191,10 +177,13 @@ export class StatelessStackCollection {
...statelessConfiguration.metadataManagerStackProps,
});

this.sequenceRunManagerStack = new SequenceRunManagerStack(scope, 'SequenceRunManagerStack', {
...this.createTemplateProps(env, 'SequenceRunManagerStack'),
...statelessConfiguration.sequenceRunManagerStackProps,
});
/**
* Migrated to https://github.com/orcabus
*/
// this.sequenceRunManagerStack = new SequenceRunManagerStack(scope, 'SequenceRunManagerStack', {
// ...this.createTemplateProps(env, 'SequenceRunManagerStack'),
// ...statelessConfiguration.sequenceRunManagerStackProps,
// });

this.bsshIcav2FastqCopyManagerStack = new BsshIcav2FastqCopyManagerStack(
scope,
Expand Down Expand Up @@ -319,10 +308,13 @@ export class StatelessStackCollection {
...statelessConfiguration.bclConvertManagerStackProps,
});

this.workflowManagerStack = new WorkflowManagerStack(scope, 'WorkflowManagerStack', {
...this.createTemplateProps(env, 'WorkflowManagerStack'),
...statelessConfiguration.workflowManagerStackProps,
});
/**
* Migrated to https://github.com/orcabus
*/
// this.workflowManagerStack = new WorkflowManagerStack(scope, 'WorkflowManagerStack', {
// ...this.createTemplateProps(env, 'WorkflowManagerStack'),
// ...statelessConfiguration.workflowManagerStackProps,
// });

this.stackyMcStackFaceStack = new GlueStack(scope, 'StackyMcStackFaceStack', {
...this.createTemplateProps(env, 'StackyMcStackFaceStack'),
Expand Down
Loading