Skip to content

fix(filemanager): ignore transient secret errors #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented May 1, 2025

Related to umccr/orca-ui#173

Changes

  • Add flag to ignore transient errors in the secrets manager cache.
  • Print the error with full context if it does occur.

Hopefully this should reduce the amount of times this occur. I'll have to look into the issue more to determine if it really is a transient error or something else. If it is a transient error and it keeps occuring, I can add a retry mechanism.

@mmalenic mmalenic self-assigned this May 1, 2025
@mmalenic mmalenic added the fix label May 1, 2025
@mmalenic mmalenic requested review from raylrui and victorskl May 1, 2025 01:04
@mmalenic
Copy link
Member Author

mmalenic commented May 1, 2025

/cc @reisingerf @andrewpatto

@mmalenic mmalenic added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit db7a9ab May 1, 2025
6 checks passed
@mmalenic mmalenic deleted the fix/filemanager-secrets-transient-errors branch May 1, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants