Added data-sharing manager and toolkit #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexiswl
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README for the data-sharing-manager by adding comprehensive instructions for using the new data-sharing-tool CLI to launch fastq manager services.
- Adds installation instructions with an explicit note to run the install command with bash.
- Provides detailed examples and command line workflows for package generation, validation, and sharing.
Files not reviewed (1)
- lib/workload/stateless/stacks/data-sharing-manager/scripts/install.sh: Language not supported
| --query 'QueryExecutionId' \ | ||
| )" | ||
|
|
||
| # Wait for the query to complete |
There was a problem hiding this comment.
Consider adding a timeout or maximum iteration count in the query wait loop to prevent potential infinite loops if the query never completes.
Suggested change
| # Wait for the query to complete | |
| # Wait for the query to complete | |
| timeout=60 # Maximum wait time in seconds | |
| elapsed=0 # Elapsed time counter |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Hey @Copilot, not sure if you'll respond to this or you just gonna ghost,
While this is a good idea, you will need to update the 'elapsed' variable each iteration and compare the elapsed variable's value with the value for the timeout. Can you complete that task?
Fix readme
alexiswl
force-pushed
the
documentation/data-sharing-manager-and-toolkit
branch
from
5393111 to
8232b6c
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
data-sharing-toolcli tool for launching fastq manager services.