Skip to content

CLDR-18536 Stored Procedure for CLA Org update #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 22, 2025

CLDR-18536

  • also adds a survey-tool/admin.md page

  • ADD_CLA_ORGS can be used to add a new CLA Org without a code change.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested a review from btangmu April 22, 2025 17:04
@srl295 srl295 self-assigned this Apr 22, 2025
@srl295 srl295 changed the title CLDR-18535 Stored Procedure for CLA Org update CLDR-18536 Stored Procedure for CLA Org update Apr 22, 2025
@srl295 srl295 force-pushed the srl295/cldr-18536/org-cla-updates branch from 507b9ec to ac3658d Compare April 22, 2025 17:14
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link

✨ deployed to https://9d2ca46d.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Apr 22, 2025
Copy link

✨ deployed to https://7b53063a.cldr.pages.dev

btangmu
btangmu previously approved these changes Apr 22, 2025
Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how one would actually go about doing this for a single user -- would one just ssh, run mysql, and copy-paste these commands at the command line?

Very minor nitpick: the sql mixes lowercase and uppercase keywords like "set" and "SET"

@srl295
Copy link
Member Author

srl295 commented Apr 22, 2025

I'm not sure how one would actually go about doing this for a single user -- would one just ssh, run mysql, and copy-paste these commands at the command line?

correct.

Very minor nitpick: the sql mixes lowercase and uppercase keywords like "set" and "SET"

ah, ok, i will fix

- update .sql per review comments
- add ADD_CLA_ORGS property to append to the CLA organizations
Copy link

✨ deployed to https://9a224175.cldr.pages.dev

Copy link

✨ deployed to https://2979d541.cldr.pages.dev

@srl295 srl295 force-pushed the srl295/cldr-18536/org-cla-updates branch from 84dd701 to 3ba964d Compare April 22, 2025 18:07
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link

✨ deployed to https://9ad0db68.cldr.pages.dev

@srl295 srl295 requested a review from DraganBesevic April 22, 2025 18:45
Copy link

✨ deployed to https://60266019.cldr.pages.dev

Copy link

✨ deployed to https://d9933d41.cldr.pages.dev

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a good thing. There are many fewer people who can ssh in to do the change than there are people who can merge in a change and then push to production. (And we don't want to open that up to many people!)

I would rather see us either have UI in the ST to add organizations, or some other method that does not involve ssh access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants