-
Notifications
You must be signed in to change notification settings - Fork 397
CLDR-18536 Stored Procedure for CLA Org update #4627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
507b9ec
to
ac3658d
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
✨ deployed to https://9d2ca46d.cldr.pages.dev |
✨ deployed to https://7b53063a.cldr.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how one would actually go about doing this for a single user -- would one just ssh, run mysql, and copy-paste these commands at the command line?
Very minor nitpick: the sql mixes lowercase and uppercase keywords like "set" and "SET"
correct.
ah, ok, i will fix |
- update .sql per review comments - add ADD_CLA_ORGS property to append to the CLA organizations
✨ deployed to https://9a224175.cldr.pages.dev |
✨ deployed to https://2979d541.cldr.pages.dev |
84dd701
to
3ba964d
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
✨ deployed to https://9ad0db68.cldr.pages.dev |
✨ deployed to https://60266019.cldr.pages.dev |
✨ deployed to https://d9933d41.cldr.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is a good thing. There are many fewer people who can ssh in to do the change than there are people who can merge in a change and then push to production. (And we don't want to open that up to many people!)
I would rather see us either have UI in the ST to add organizations, or some other method that does not involve ssh access.
CLDR-18536
also adds a
survey-tool/admin.md
pageADD_CLA_ORGS
can be used to add a new CLA Org without a code change.This PR completes the ticket.
ALLOW_MANY_COMMITS=true