-
Notifications
You must be signed in to change notification settings - Fork 397
CLDR-17829 move PathDescriptions.txt to PathDescriptions.md #4633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17829 move PathDescriptions.txt to PathDescriptions.md #4633
Conversation
- add lychee build task to link check. - added PathDescriptionParser and unit tests
- fix unneeded HTML escaping - add cldrDom.setDocTargets() so the server doesn't need to munge content - update test
- fix site reference - remove old todos
description = MISSING_DESCRIPTION; | ||
} else if ("SKIP".equals(description)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it starts with SKIP, but has other characters, it is an error; so best to raise an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the description here is more rich, it's for you to name (or in the future group) these entries.
as below, where First Day of the Week is a comment.
### First Day of the Week
- `^//ldml/localeDisplayNames/types/type\[@key="fw"]\[@type="([^"]*)"]`
The name of “first day of the week is {1}”. For more information, please see [Key Names].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand ... that snippet does not have SKIP in it
tools/cldr-code/src/test/java/org/unicode/cldr/util/TestPathDescription.java
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/PathDescriptions.md
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/PathDescriptions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor except for the "#h."
tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/PathDescriptions.md
Outdated
Show resolved
Hide resolved
…/util/data/PathDescriptions.md Co-authored-by: Mark Davis <mark@unicode.org>
@macchiati some of the other targets don't seem to exist. |
"Cyclic Name Sets" isn't an anchor (defect in date-time-names.md ) |
I thought this task was to move the format over, for future fixup. I will revisit this tomorow |
I'll add a test against the relevant sites page… Probably for a future PR |
I just thought that as long as you were getting the anchor text, you could fix the links as well. It can be a separate PR though. |
No, i had just title cased the variable names. |
All #h. fragments removed and corrected as best I can.
So probably all of these need review. |
- copy changes from unicode-org#4630 into PathDescriptions.md
- fix broken placeholders - correct CSS issue
I was thinking that for this file and similar ones, it would be useful to have a tool that generated a sample of each message, that would be used to build a web page; we could then review to make sure that all the parameters were right, etc. Not part of this ticket — I'll file a different one for it. |
- add test that no placeholders leak through - fix additional paths
- test was failing because URLs are now in the references instead of inline
sorry, i was running the wrong test locally. This also now fixes a number of cases where the placeholders |
i recommend deduping cases where the message is the same for multiple xpaths. |
That's what I meant by one message per line, eg per regex path in the <key, values> pair. |
CLDR-17829
ALLOW_MANY_COMMITS=true