Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core::error #5973

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Use core::error #5973

merged 4 commits into from
Jan 13, 2025

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jan 10, 2025

Fixes #5964

The only remaining uses of std are:

  • DataError::Io and DataError::with_path
    • with_path can be replaced by with_display_context(path.display()), but the std::io::ErrorKind is not in core (it could be, it's a fieldless enum).
  • icu_provider::log falling back to println! (negative logging feature)
  • icu_capi keeps its std feature, as that's required to build a static library with panic=unwind. I'm not sure what the use case for this is, but we use it as a baseline in the size benchmark.

@robertbastian robertbastian force-pushed the 81 branch 3 times, most recently from ff8e0ed to 7e26527 Compare January 13, 2025 10:12
@Manishearth
Copy link
Member

All three of those cases seem fine by me.

I would also be okay with erasing the Io error context (Io errors rarely contain enough information _anyway)) in DataError, btu we don't really need to so let's leave it as is.

@Manishearth
Copy link
Member

Is there a reason this is not "fixes #5964"?

@robertbastian robertbastian merged commit 263fdc2 into unicode-org:main Jan 13, 2025
28 checks passed
@robertbastian robertbastian deleted the 81 branch January 13, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment MSRV to 1.81 and use core::error::Error
2 participants