More no-alloc #6166
Open
More no-alloc #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
hsivonen,
echeran,
zbraniecki,
nciric and
a team
as code owners
Manishearth
previously approved these changes
Feb 20, 2025
| @@ -130,6 +130,7 @@ struct EyepatchHackVector<U> { | |||
| /// This pointer is *always* valid, the reason it is represented as a raw pointer | |||
| /// is that it may logically represent an `&[T::ULE]` or the ptr,len of a `Vec<T::ULE>` | |||
| buf: NonNull<[U]>, | |||
| #[cfg(feature = "alloc")] | |||
There was a problem hiding this comment.
not: explicitly document behavior when not present
There was a problem hiding this comment.
hm? there's no behaviour change, this is just always 0 in no-alloc
There was a problem hiding this comment.
I understand, however this is unsafe code, we should be doubly clear about how things change. "This field is equivalent to 0 when disabled" is fine
Manishearth
previously approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icu_time,icu_decimal,icu_list#6076