Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surt browse #116

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix surt browse #116

merged 3 commits into from
Sep 13, 2024

Conversation

ldko
Copy link
Member

@ldko ldko commented Sep 13, 2024

This is to fix #114 and #115.

  • Regarding Nominating an URL length 255-300 chars responds with a 404 #114: A user can nominate URLs of up to 300 characters in length. When nominating a URL, a surt attribute is created to hold in value a SURT form of the URL. The SURT form of an URL can be a few characters longer than the URL, so this PR increases the allowed length of value to 305 to accommodate the longest URLs' SURT forms.
  • Regarding Surt browse for TLDs may return out-of-scope results #115: on a project's url listing page, top level domains are given as links to a listing of URLs matching the SURT prefix of the top level domain. The SURT prefix, should end in a comma, but the way we are using the top-level domain in our browse structure and with how we are displaying the link text, we don't look up SURT values currently with the comma which causes matches for .co to include .com etc. Adding a comma to the template link allows for going to the correct SURT prefix for the view.

ping @clarktr1 @somexpert this is ready for review

@ldko ldko added the bug-fix label Sep 13, 2024
@ldko ldko requested review from somexpert and clarktr1 September 13, 2024 17:14
Copy link
Member

@somexpert somexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! 👍

Copy link

@clarktr1 clarktr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ldko ldko merged commit 750b10e into master Sep 13, 2024
6 checks passed
@ldko ldko deleted the fix-surt-browse branch September 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nominating an URL length 255-300 chars responds with a 404
3 participants