-
Notifications
You must be signed in to change notification settings - Fork 0
Refactored mpirun to not exec a second executable #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: capstone-devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
804d3c6
to
34fe233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, but we'll need to get the changes in prrte for adding prte_launch to the prte.h include file.
We will need for uofl-capstone-open-mpi/prrte#6 to be merged in then move the prrte sha in the capstone ompi repo forward to pick that change up before CI can pass for this PR.
@gagarc I think you need to rebase to the tip of You may find it easier to drop your prrte git submodule update, then rebase, then re-create your prrte git submodule update. |
6d405ce
to
9499b9d
Compare
@hppritcha The mpi4py CI failure here is legit. It stems from the OMPI DPM looking for the Do we need a PRTE library way to start a DVM? |
oopss it looks like a change on the prrte side caused the |
9499b9d
to
9437036
Compare
okay now just getting known comm create from group thing in mpi4py. rerunning. |
…he function directly in the process Note this commit will need to be adjusted to reset .gitmodules before merging into Open MPI main Signed-off-by: Gerardo Garcia <gagarc07@louisville.edu> Signed-off-by: Howard Pritchard <howardp@lanl.gov>
79a0da3
to
9b7b0a4
Compare
Modified mpirun to no longer fork/exec prterun, but to instead instead call the function directly