Skip to content

Commit db9b6ed

Browse files
committed
bump-version: docker does not like +
1 parent e9e3716 commit db9b6ed

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

bump-version/version.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type version struct {
1313
}
1414

1515
func parse(t string) (*version, error) {
16-
v, err := semver.NewVersion(t)
16+
v, err := semver.NewVersion(strings.Replace(t, "_", "+", -1))
1717

1818
if err != nil {
1919
return nil, err
@@ -55,7 +55,7 @@ func (v *version) RC() int64 {
5555
}
5656

5757
func (v *version) String() string {
58-
return fmt.Sprintf("v%s", v.Version.String())
58+
return strings.Replace(fmt.Sprintf("v%s", v.Version.String()), "+", "_", -1)
5959
}
6060

6161
func (v *version) Compare(v2 *version) int {

bump-version/version_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ func TestStrategy(t *testing.T) {
2222
{
2323
have: "v0.0.0",
2424
strategy: bumpPre,
25-
want: "v0.0.1-rc1+pre1",
25+
want: "v0.0.1-rc1_pre1",
2626
},
2727
{
28-
have: "v0.0.1-rc1+pre1",
28+
have: "v0.0.1-rc1_pre1",
2929
strategy: bumpRC,
3030
want: "v0.0.1-rc2",
3131
},
3232
{
33-
have: "v0.0.1-rc1+pre1",
33+
have: "v0.0.1-rc1_pre1",
3434
strategy: bumpMajor,
3535
want: "v1.0.0",
3636
},

0 commit comments

Comments
 (0)