Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static operators #6

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Add static operators #6

merged 4 commits into from
Jun 28, 2024

Conversation

GaelLnz
Copy link
Contributor

@GaelLnz GaelLnz commented Jun 27, 2024

What does this PR do?

Adds missing static operators

Fixes #

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Additional Notes

@GaelLnz GaelLnz requested review from AlexisMontagne and a team as code owners June 27, 2024 13:35
@GaelLnz GaelLnz requested review from BillotP and removed request for a team June 27, 2024 13:35
@GaelLnz
Copy link
Contributor Author

GaelLnz commented Jun 27, 2024

There were no test on StaticIn method so I didn't added tests either

Copy link
Member

@Sypheos Sypheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the .github/worflows with the normal lib ones ? ex:
https://github.com/upfluence/uhttp-go/blob/master/.github/workflows/ci.yaml

and make sure to added the with-cassandra: true

@GaelLnz
Copy link
Contributor Author

GaelLnz commented Jun 28, 2024

@Sypheos Looks like I can't use a private action from a public repo. So I just fixed the tests here
image

@GaelLnz GaelLnz merged commit 732f0f1 into master Jun 28, 2024
4 checks passed
@GaelLnz GaelLnz deleted the cqlbuilder/add-static-gt branch June 28, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants