[VEL-3593/VEL-3588] Remove unused ember-tether (#397)

* remove unused ember-tether

* fix Run loop and computed dot access deprecation

* remove comments

* feature-flagged: fix property access ambiguous path

Author: phndiaye

addon/activity-notifier/service.js

@@ -1,6 +1,6 @@
 import { alias, notEmpty } from '@ember/object/computed';
 import Service, { inject as service } from '@ember/service';
-import { run } from '@ember/runloop';
+import { cancel, later } from '@ember/runloop';
 import { observer } from '@ember/object';
 import { getOwner } from '@ember/application';
 import Configuration from '@upfluence/ember-upf-utils/configuration';
@@ -61,7 +61,7 @@ export default Service.extend({
     this._isRunning = false;
 
     if (this._timer) {
-      run.cancel(this._timer);
+      cancel(this._timer);
     }
   },
 
@@ -80,7 +80,7 @@ export default Service.extend({
       .then((p) => {
         this._from = p.next;
         this.displayNotifications(p.notifications);
-        this._timer = run.later(this, this.fetchNotifications, this.waitTime());
+        this._timer = later(this, this.fetchNotifications, this.waitTime());
       })
       .finally(() => {
         this._inFetch = false;

addon/components/feature-flagged/template.hbs

@@ -1,4 +1,4 @@
-{{#if allowedFeature}}
+{{#if this.allowedFeature}}
   {{yield}}
 {{else}}
   {{yield to="inverse"}}

addon/mixins/activity-runner.js

@@ -1,12 +1,12 @@
-import { inject as service } from '@ember/service';
 import Mixin from '@ember/object/mixin';
-import { run } from '@ember/runloop';
+import { later } from '@ember/runloop';
+import { inject as service } from '@ember/service';
 
 export default Mixin.create({
   activityNotifier: service(),
 
   init() {
     this._super();
-    run.later(this, () => this.activityNotifier.start(), 3000);
+    later(this, () => this.activityNotifier.start(), 3000);
   }
 });

package.json

@@ -45,7 +45,6 @@
     "ember-cli-less": "^2.0.6",
     "ember-cli-typescript": "^4.2.1",
     "ember-named-blocks-polyfill": "^0.2.4",
-    "ember-tether": "^1.0.0-beta.2",
     "ember-uploader": "^2.x",
     "moment": "^2.29.4",
     "tinycolor2": "^1.4.1"

pnpm-lock.yaml

@@ -2,21 +2,6 @@
 
 const browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'];
 
-// Ember's browser support policy is changing, and IE11 support will end in
-// v4.0 onwards.
-//
-// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
-//
-// If you need IE11 support on a version of Ember that still offers support
-// for it, uncomment the code block below.
-//
-// const isCI = Boolean(process.env.CI);
-// const isProduction = process.env.EMBER_ENV === 'production';
-//
-// if (isCI || isProduction) {
-//   browsers.push('ie 11');
-// }
-
 module.exports = {
   browsers
 };