Skip to content

Commit 6fd05fb

Browse files
committed
linter fix
1 parent 339276f commit 6fd05fb

File tree

11 files changed

+21
-120
lines changed

11 files changed

+21
-120
lines changed

.template-lintrc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
extends: 'recommended',
4+
extends: 'recommended'
55
};

config/ember-try.js

-84
This file was deleted.

ember-cli-build.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ module.exports = function (defaults) {
1919
return maybeEmbroider(app, {
2020
skipBabel: [
2121
{
22-
package: 'qunit',
23-
},
24-
],
22+
package: 'qunit'
23+
}
24+
]
2525
});
2626
};

index.js

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ module.exports = {
1717
includePolyfill: true
1818
},
1919
babel: {
20+
/* eslint-disable node/no-unpublished-require */
2021
plugins: [...require('ember-cli-code-coverage').buildBabelPlugin()]
2122
}
2223
},

testem.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ module.exports = {
1616
'--disable-software-rasterizer',
1717
'--mute-audio',
1818
'--remote-debugging-port=0',
19-
'--window-size=1440,900',
20-
].filter(Boolean),
21-
},
22-
},
19+
'--window-size=1440,900'
20+
].filter(Boolean)
21+
}
22+
}
2323
};

tests/dummy/config/ember-cli-update.json

-20
This file was deleted.

tests/dummy/config/environment.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ module.exports = function (environment) {
1414
},
1515
EXTEND_PROTOTYPES: {
1616
// Prevent Ember Data from overriding Date.parse.
17-
Date: false,
18-
},
17+
Date: false
18+
}
1919
},
2020

2121
APP: {
2222
// Here you can pass flags/options to your application instance
2323
// when it is created
24-
},
24+
}
2525
};
2626

2727
if (environment === 'development') {

tests/integration/components/u-edit/shared-triggers/modals/image-upload-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ module('Integration | Component | u-edit/shared-triggers/modals/image-upload', f
2828
});
2929

3030
test('an image is correctly added via its url in the editor', async function (assert) {
31+
assert.expect(2);
32+
3133
this.displayImageUpload = true;
3234
this.insertImage = (url) => {
3335
assert.equal(url, 'https://via.placeholder.com/350x150');
@@ -41,7 +43,5 @@ module('Integration | Component | u-edit/shared-triggers/modals/image-upload', f
4143
assert.dom('.uedit-file-uploader button.upf-btn.upf-btn--primary').hasNoAttribute('disabled');
4244

4345
await click('.uedit-file-uploader button.upf-btn.upf-btn--primary');
44-
45-
assert.expect(2);
4646
});
4747
});

tests/integration/components/u-edit/shared-triggers/modals/pdf-upload-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ module('Integration | Component | u-edit/shared-triggers/modals/pdf-upload', fun
2828
});
2929

3030
test('an image is correctly added via its url in the editor', async function (assert) {
31+
assert.expect(2);
32+
3133
this.displayImageUpload = true;
3234
this.insertPDF = (url) => {
3335
assert.equal(url, 'http://www.africau.edu/images/default/sample.pdf');
@@ -41,7 +43,5 @@ module('Integration | Component | u-edit/shared-triggers/modals/pdf-upload', fun
4143
assert.dom('.uedit-file-uploader button.upf-btn.upf-btn--primary').hasNoAttribute('disabled');
4244

4345
await click('.uedit-file-uploader button.upf-btn.upf-btn--primary');
44-
45-
assert.expect(2);
4646
});
4747
});

tests/integration/components/utils/address-form-test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ module('Integration | Component | utils/address-form', function (hooks) {
196196
assert.dom('[data-control-name="address-form-state"]').hasClass('oss-input-container');
197197
});
198198

199-
test('onChange action is called with truthy validity check when all fields are filled', async function (assert) {
199+
test('onChange action is called with truthy validity check when all fields but the state are filled as it is optional', async function (assert) {
200200
await render(
201201
hbs`<Utils::AddressForm @address={{this.address}} @usePhoneNumberInput={{true}} @useGoogleAutocomplete={{false}}
202202
@onChange={{this.onChange}} />`

tests/unit/services/activity-watcher-test.ts

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable qunit/no-conditional-assertions */
12
import { module, test } from 'qunit';
23
import { setupTest } from 'ember-qunit';
34

@@ -146,6 +147,8 @@ module('Unit | Service | activity-watcher', function (hooks) {
146147

147148
eventTypesTestCases.forEach((testCase: any) => {
148149
test('it dispatches events for ' + testCase.notification.notification_type, function (assert) {
150+
assert.expect(3);
151+
149152
const infoStub = sinon
150153
.stub(this.owner.lookup('service:toast'), 'info')
151154
.callsFake((message: string, title: string) => {
@@ -180,3 +183,4 @@ function trimAll(str: string): string {
180183
//@ts-ignore
181184
return str.replaceAll(' ', '');
182185
}
186+
/* eslint-enable qunit/no-conditional-assertions */

0 commit comments

Comments
 (0)