Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEL-3593] Upgrade to ember 3.28 #395

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

phndiaye
Copy link
Member

@phndiaye phndiaye commented Jul 3, 2024

What does this PR do?

Upgrade to ember 3.28

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@phndiaye phndiaye requested a review from a team as a code owner July 3, 2024 11:39
@phndiaye phndiaye requested review from Xegushu, Miexil and OwenCoogan and removed request for a team July 3, 2024 11:39
@phndiaye phndiaye self-assigned this Jul 3, 2024
@phndiaye phndiaye force-pushed the pn/chore/ember-3.28-upgrade branch from 9bd747a to 6fd05fb Compare July 24, 2024 06:46
@phndiaye phndiaye changed the title Upgrade to ember 3.28 [VEL-3593] Upgrade to ember 3.28 Jul 24, 2024
Copy link

linear bot commented Jul 24, 2024

* remove unused ember-tether

* fix Run loop and computed dot access deprecation

* remove comments

* feature-flagged: fix property access ambiguous path
@phndiaye phndiaye merged commit 40c22c3 into master Jul 25, 2024
2 checks passed
@phndiaye phndiaye deleted the pn/chore/ember-3.28-upgrade branch July 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants