Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cooldown] Remove sendAction from side-hover-panel & ts format #398

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

JulienVannier66
Copy link
Contributor

@JulienVannier66 JulienVannier66 commented Aug 9, 2024

What does this PR do?

Remove sendAction from side-hover-panel & ts format. Also remove the unused component drap-and-drop

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Aug 9, 2024
@JulienVannier66 JulienVannier66 requested review from phndiaye and a team as code owners August 9, 2024 15:32
@JulienVannier66 JulienVannier66 requested review from Xegushu and nathalieArnoux and removed request for a team August 9, 2024 15:32
Copy link

linear bot commented Aug 9, 2024

@JulienVannier66 JulienVannier66 marked this pull request as ready for review October 2, 2024 10:00
@JulienVannier66 JulienVannier66 force-pushed the jv/vel-3566/send-action-deprecation branch from 9b9876d to 74573ee Compare October 4, 2024 09:47
@JulienVannier66 JulienVannier66 merged commit b81e1cb into master Oct 4, 2024
2 checks passed
@JulienVannier66 JulienVannier66 deleted the jv/vel-3566/send-action-deprecation branch October 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants