Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override flatpickrs style to match our branding #400

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Override flatpickrs style to match our branding #400

merged 2 commits into from
Sep 19, 2024

Conversation

phndiaye
Copy link
Member

What does this PR do?

Override flatpickrs style to match our branding

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@phndiaye phndiaye requested a review from a team as a code owner September 17, 2024 08:06
@phndiaye phndiaye requested review from Miexil, aprentout and nathalieArnoux and removed request for a team September 17, 2024 08:06
@linear Linear
Copy link

linear bot commented Sep 17, 2024

VEL-3604 Update datepicker component throughout the software.

@phndiaye phndiaye self-assigned this Sep 17, 2024
@phndiaye phndiaye mentioned this pull request Sep 17, 2024
Closed
8 tasks
@OwenCoogan OwenCoogan self-requested a review September 17, 2024 08:41
@phndiaye phndiaye merged commit ed58124 into master Sep 19, 2024
2 checks passed
@phndiaye phndiaye deleted the pn/vel-3604 branch September 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xegushu Xegushu Xegushu approved these changes

@Miexil Miexil Miexil approved these changes

@OwenCoogan OwenCoogan OwenCoogan approved these changes

@JulienVannier66 JulienVannier66 JulienVannier66 approved these changes

@aprentout aprentout Awaiting requested review from aprentout aprentout is a code owner automatically assigned from upfluence/frontend

@nathalieArnoux nathalieArnoux Awaiting requested review from nathalieArnoux nathalieArnoux is a code owner automatically assigned from upfluence/frontend

Assignees

@phndiaye phndiaye

Labels
reviewed/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@phndiaye @Xegushu @Miexil @OwenCoogan @JulienVannier66 @upfluence-bot