Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed instance of upf-icon #402

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: removed instance of upf-icon #402

merged 1 commit into from
Nov 8, 2024

Conversation

OwenCoogan
Copy link
Contributor

What does this PR do?

Related to: #

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Copy link

linear bot commented Oct 2, 2024

@OwenCoogan OwenCoogan marked this pull request as ready for review November 5, 2024 16:56
@OwenCoogan OwenCoogan requested review from phndiaye and a team as code owners November 5, 2024 16:56
@OwenCoogan OwenCoogan requested review from Xegushu and nathalieArnoux and removed request for a team November 5, 2024 16:56
@OwenCoogan OwenCoogan merged commit eda17ad into master Nov 8, 2024
2 checks passed
@OwenCoogan OwenCoogan deleted the oc/VEL-3603 branch November 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants