Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM 8 to 10 #410

Merged
merged 3 commits into from
Jan 14, 2025
Merged

PNPM 8 to 10 #410

merged 3 commits into from
Jan 14, 2025

Conversation

phndiaye
Copy link
Member

What does this PR do?

PNPM 8 to 10

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@phndiaye phndiaye requested a review from a team as a code owner January 13, 2025 09:46
@phndiaye phndiaye requested review from JulienVannier66, aprentout and nathalieArnoux and removed request for a team January 13, 2025 09:46
Copy link

linear bot commented Jan 13, 2025

@phndiaye phndiaye merged commit 9701756 into master Jan 14, 2025
2 checks passed
@phndiaye phndiaye deleted the pn/vel-4622 branch January 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants