Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypertable v2: use the header's column as draggable handle #234

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hypertable v2: use the header's column as draggable handle #234

wants to merge 3 commits into from

Conversation

phndiaye
Copy link
Member

What does this PR do?

Currently, when a column is draggable, it's whole content can be used as handle (including the rows' cells), leading to weird behaviours.

This PR ensures users can only drag a column by its header using ember-sortable's sortable-handle modifier.

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested a review from a team as a code owner March 14, 2025 10:00
@phndiaye phndiaye requested review from OwenCoogan, olxmpe and aprentout and removed request for a team March 14, 2025 10:00
@phndiaye phndiaye self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miexil Miexil Miexil approved these changes

@OwenCoogan OwenCoogan OwenCoogan approved these changes

@JulienVannier66 JulienVannier66 JulienVannier66 approved these changes

@aprentout aprentout aprentout approved these changes

@nathalieArnoux nathalieArnoux nathalieArnoux approved these changes

@olxmpe olxmpe Awaiting requested review from olxmpe olxmpe is a code owner automatically assigned from upfluence/frontend

Assignees

@phndiaye phndiaye

Labels
reviewed/ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@phndiaye @Miexil @OwenCoogan @JulienVannier66 @aprentout @nathalieArnoux @upfluence-bot