From 8a728b66a21d7ad4e762fa363096071b5422262e Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Mon, 3 Feb 2025 11:13:15 +0100 Subject: [PATCH 1/8] wip --- addon/components/o-s-s/empty-state.hbs | 13 ++++++++++ addon/components/o-s-s/empty-state.ts | 11 ++++++++ app/components/o-s-s/empty-state.js | 1 + tests/dummy/app/templates/index.hbs | 16 ++++++++++++ .../components/o-s-s/empty-state-test.ts | 26 +++++++++++++++++++ 5 files changed, 67 insertions(+) create mode 100644 addon/components/o-s-s/empty-state.hbs create mode 100644 addon/components/o-s-s/empty-state.ts create mode 100644 app/components/o-s-s/empty-state.js create mode 100644 tests/integration/components/o-s-s/empty-state-test.ts diff --git a/addon/components/o-s-s/empty-state.hbs b/addon/components/o-s-s/empty-state.hbs new file mode 100644 index 00000000..244d32c6 --- /dev/null +++ b/addon/components/o-s-s/empty-state.hbs @@ -0,0 +1,13 @@ +
+
+ {{@title}} +
+
+ {{@subtitle}} +
+ {{#if (has-block "actions")}} + + {{yield to="actions"}} + + {{/if}} +
\ No newline at end of file diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts new file mode 100644 index 00000000..09c861f0 --- /dev/null +++ b/addon/components/o-s-s/empty-state.ts @@ -0,0 +1,11 @@ +import type { htmlSafe } from '@ember/template'; +import Component from '@glimmer/component'; + +interface OSSEmptyStateComponentSignature { + image?: string; + title?: ReturnType; + subtitle?: ReturnType; + size?: 'sm' | 'md'; +} + +export default class OSSEmptyStateComponent extends Component {} diff --git a/app/components/o-s-s/empty-state.js b/app/components/o-s-s/empty-state.js new file mode 100644 index 00000000..7f68cc78 --- /dev/null +++ b/app/components/o-s-s/empty-state.js @@ -0,0 +1 @@ +export { default } from '@upfluence/oss-components/components/o-s-s/empty-state'; diff --git a/tests/dummy/app/templates/index.hbs b/tests/dummy/app/templates/index.hbs index c699a333..2f4cf3d6 100644 --- a/tests/dummy/app/templates/index.hbs +++ b/tests/dummy/app/templates/index.hbs @@ -276,4 +276,20 @@ +
+
+ Empty state +
+
+ + <:actions> + + + + +
+
+ \ No newline at end of file diff --git a/tests/integration/components/o-s-s/empty-state-test.ts b/tests/integration/components/o-s-s/empty-state-test.ts new file mode 100644 index 00000000..dacacc7d --- /dev/null +++ b/tests/integration/components/o-s-s/empty-state-test.ts @@ -0,0 +1,26 @@ +import { module, test } from 'qunit'; +import { setupRenderingTest } from 'ember-qunit'; +import { render } from '@ember/test-helpers'; +import { hbs } from 'ember-cli-htmlbars'; + +module('Integration | Component | o-s-s/empty-state', function (hooks) { + setupRenderingTest(hooks); + + test('it renders', async function (assert) { + // Set any properties with this.set('myProperty', 'value'); + // Handle any actions with this.set('myAction', function (val) { ... }); + + await render(hbs``); + + assert.dom().hasText(''); + + // Template block usage: + await render(hbs` + + template block text + + `); + + assert.dom().hasText('template block text'); + }); +}); From 299490360de2f7a11250b635851936dddfe18269 Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Wed, 19 Feb 2025 15:32:08 +0100 Subject: [PATCH 2/8] component done --- addon/components/o-s-s/empty-state.hbs | 21 +++++++++++++++------ addon/components/o-s-s/empty-state.ts | 10 +++++++++- tests/dummy/app/templates/index.hbs | 24 ++++++++++++++++++++++++ 3 files changed, 48 insertions(+), 7 deletions(-) diff --git a/addon/components/o-s-s/empty-state.hbs b/addon/components/o-s-s/empty-state.hbs index 244d32c6..b0484e9e 100644 --- a/addon/components/o-s-s/empty-state.hbs +++ b/addon/components/o-s-s/empty-state.hbs @@ -1,9 +1,18 @@ -
-
- {{@title}} -
-
- {{@subtitle}} +
+ {{#if (has-block "image")}} + + {{yield to="image"}} + + {{else if @image}} + + {{/if}} +
+
+ {{@title}} +
+
+ {{@subtitle}} +
{{#if (has-block "actions")}} diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts index 09c861f0..5503d6f7 100644 --- a/addon/components/o-s-s/empty-state.ts +++ b/addon/components/o-s-s/empty-state.ts @@ -8,4 +8,12 @@ interface OSSEmptyStateComponentSignature { size?: 'sm' | 'md'; } -export default class OSSEmptyStateComponent extends Component {} +export default class OSSEmptyStateComponent extends Component { + get titleSize(): string { + return this.args.size === 'sm' ? 'md' : 'lg'; + } + + get subtitleSize(): string { + return this.args.size || 'md'; + } +} diff --git a/tests/dummy/app/templates/index.hbs b/tests/dummy/app/templates/index.hbs index 2f4cf3d6..9255f1ae 100644 --- a/tests/dummy/app/templates/index.hbs +++ b/tests/dummy/app/templates/index.hbs @@ -284,6 +284,30 @@
+ <:image> + + + <:actions> + + + + + + <:actions> + + + + + + <:image> + + + <:actions> + + + + + <:actions> From 1540675454547ef819deb895cd215d16b6a02ed5 Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Wed, 19 Feb 2025 16:36:52 +0100 Subject: [PATCH 3/8] added tests and stories --- addon/components/o-s-s/empty-state.stories.js | 71 +++++++++++++++++++ .../components/o-s-s/empty-state-test.ts | 51 ++++++++++--- 2 files changed, 113 insertions(+), 9 deletions(-) create mode 100644 addon/components/o-s-s/empty-state.stories.js diff --git a/addon/components/o-s-s/empty-state.stories.js b/addon/components/o-s-s/empty-state.stories.js new file mode 100644 index 00000000..271b472b --- /dev/null +++ b/addon/components/o-s-s/empty-state.stories.js @@ -0,0 +1,71 @@ +import { hbs } from 'ember-cli-htmlbars'; + +export default { + title: 'Components/OSS::EmptyState', + component: 'empty state', + argTypes: { + image: { + description: 'a font-awesome icon to be displayed in a badge', + table: { + type: { + summary: 'string' + }, + defaultValue: { summary: 'undefined' } + }, + control: { type: 'text' } + }, + title: { + description: 'The title of the state', + table: { + type: { + summary: 'string' + }, + defaultValue: { summary: 'undefined' } + }, + control: { type: 'text' } + }, + subtitle: { + description: 'More information about the state', + table: { + type: { + summary: 'string' + }, + defaultValue: { summary: 'undefined' } + }, + control: { type: 'text' } + }, + size: { + description: 'The size of the state', + table: { + type: { + summary: 'string' + }, + defaultValue: { summary: 'undefined' } + }, + control: { type: 'select' }, + options: ['sm', 'md'] + } + }, + parameters: { + docs: { + description: { + component: 'An component used when there is nothing to display on a page' + } + } + } +}; + +const defaultArgs = { + image: 'fa-thumbs-up', + title: 'Empty State Title', + subtitle: 'Additional information here', + size: 'md' +}; + +const Template = (args) => ({ + template: hbs``, + context: args +}); + +export const Default = Template.bind({}); +Default.args = defaultArgs; diff --git a/tests/integration/components/o-s-s/empty-state-test.ts b/tests/integration/components/o-s-s/empty-state-test.ts index dacacc7d..111693e9 100644 --- a/tests/integration/components/o-s-s/empty-state-test.ts +++ b/tests/integration/components/o-s-s/empty-state-test.ts @@ -6,21 +6,54 @@ import { hbs } from 'ember-cli-htmlbars'; module('Integration | Component | o-s-s/empty-state', function (hooks) { setupRenderingTest(hooks); - test('it renders', async function (assert) { - // Set any properties with this.set('myProperty', 'value'); - // Handle any actions with this.set('myAction', function (val) { ... }); + test('it renders with default properties', async function (assert) { + await render(hbs``); - await render(hbs``); + assert.dom('div.font-color-gray-900').hasText('No Data'); + assert.dom('div.font-color-gray-500').hasText('Try again later'); + assert.dom('span').doesNotExist(); + }); + + test('it renders with an image', async function (assert) { + this.set('image', 'fa-thumbs-up'); + await render(hbs``); - assert.dom().hasText(''); + assert.dom('div.font-color-gray-900').hasText('No Data'); + assert.dom('div.font-color-gray-500').hasText('Try again later'); + assert.dom('.upf-badge').exists(); + }); - // Template block usage: + test('it supports block usage for image', async function (assert) { await render(hbs` - - template block text + + <:image> + Test Image + `); - assert.dom().hasText('template block text'); + assert.dom('div.font-color-gray-900').hasText('No Data'); + assert.dom('div.font-color-gray-500').hasText('Try again later'); + assert.dom('span img').exists(); + }); + + test('it supports block usage for actions', async function (assert) { + await render(hbs` + + <:actions> + + + + `); + + assert.dom('div.font-color-gray-900').hasText('No Data'); + assert.dom('div.font-color-gray-500').hasText('Try again later'); + assert.dom('span button').hasText('Retry'); + }); + + test('it applies size-based styles', async function (assert) { + await render(hbs``); + assert.dom('div.font-color-gray-900').hasClass('font-size-md'); + assert.dom('div.font-color-gray-500').hasClass('font-size-sm'); }); }); From fb6a3cf47d92bfd0a82057646828f70e61289185 Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Wed, 19 Feb 2025 17:30:03 +0100 Subject: [PATCH 4/8] feedback fixes --- addon/components/o-s-s/empty-state.hbs | 18 +++++++----------- addon/components/o-s-s/empty-state.stories.js | 6 +++--- addon/components/o-s-s/empty-state.ts | 12 ++++++------ tests/dummy/app/templates/index.hbs | 4 ++-- .../components/o-s-s/empty-state-test.ts | 9 ++++----- 5 files changed, 22 insertions(+), 27 deletions(-) diff --git a/addon/components/o-s-s/empty-state.hbs b/addon/components/o-s-s/empty-state.hbs index b0484e9e..e7ab9343 100644 --- a/addon/components/o-s-s/empty-state.hbs +++ b/addon/components/o-s-s/empty-state.hbs @@ -1,22 +1,18 @@
{{#if (has-block "image")}} - - {{yield to="image"}} - - {{else if @image}} - + {{yield to="image"}} + {{else if @badgeIcon}} + {{/if}} -
+
{{@title}}
-
+
{{@subtitle}}
-
+ {{#if (has-block "actions")}} - - {{yield to="actions"}} - + {{yield to="actions"}} {{/if}}
\ No newline at end of file diff --git a/addon/components/o-s-s/empty-state.stories.js b/addon/components/o-s-s/empty-state.stories.js index 271b472b..ef5381d1 100644 --- a/addon/components/o-s-s/empty-state.stories.js +++ b/addon/components/o-s-s/empty-state.stories.js @@ -4,7 +4,7 @@ export default { title: 'Components/OSS::EmptyState', component: 'empty state', argTypes: { - image: { + badgeIcon: { description: 'a font-awesome icon to be displayed in a badge', table: { type: { @@ -56,14 +56,14 @@ export default { }; const defaultArgs = { - image: 'fa-thumbs-up', + badgeIcon: 'fa-thumbs-up', title: 'Empty State Title', subtitle: 'Additional information here', size: 'md' }; const Template = (args) => ({ - template: hbs``, + template: hbs``, context: args }); diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts index 5503d6f7..8cdf210d 100644 --- a/addon/components/o-s-s/empty-state.ts +++ b/addon/components/o-s-s/empty-state.ts @@ -2,18 +2,18 @@ import type { htmlSafe } from '@ember/template'; import Component from '@glimmer/component'; interface OSSEmptyStateComponentSignature { - image?: string; - title?: ReturnType; - subtitle?: ReturnType; + badgeIcon?: string; + title: ReturnType; + subtitle: ReturnType; size?: 'sm' | 'md'; } export default class OSSEmptyStateComponent extends Component { get titleSize(): string { - return this.args.size === 'sm' ? 'md' : 'lg'; + return this.size === 'sm' ? 'md' : 'lg'; } - get subtitleSize(): string { - return this.args.size || 'md'; + get size(): string { + return this.args.size && ['sm', 'md'].includes(this.args.size) ? this.args.size : 'md'; } } diff --git a/tests/dummy/app/templates/index.hbs b/tests/dummy/app/templates/index.hbs index 9255f1ae..09c48316 100644 --- a/tests/dummy/app/templates/index.hbs +++ b/tests/dummy/app/templates/index.hbs @@ -292,7 +292,7 @@ - + <:actions> @@ -307,7 +307,7 @@ - + <:actions> diff --git a/tests/integration/components/o-s-s/empty-state-test.ts b/tests/integration/components/o-s-s/empty-state-test.ts index 111693e9..af7e03d4 100644 --- a/tests/integration/components/o-s-s/empty-state-test.ts +++ b/tests/integration/components/o-s-s/empty-state-test.ts @@ -11,12 +11,11 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('div.font-color-gray-900').hasText('No Data'); assert.dom('div.font-color-gray-500').hasText('Try again later'); - assert.dom('span').doesNotExist(); }); - test('it renders with an image', async function (assert) { + test('it renders with a badge icon', async function (assert) { this.set('image', 'fa-thumbs-up'); - await render(hbs``); + await render(hbs``); assert.dom('div.font-color-gray-900').hasText('No Data'); assert.dom('div.font-color-gray-500').hasText('Try again later'); @@ -34,7 +33,7 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('div.font-color-gray-900').hasText('No Data'); assert.dom('div.font-color-gray-500').hasText('Try again later'); - assert.dom('span img').exists(); + assert.dom('img').exists(); }); test('it supports block usage for actions', async function (assert) { @@ -48,7 +47,7 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('div.font-color-gray-900').hasText('No Data'); assert.dom('div.font-color-gray-500').hasText('Try again later'); - assert.dom('span button').hasText('Retry'); + assert.dom('button').hasText('Retry'); }); test('it applies size-based styles', async function (assert) { From 438695147eaf1be719449ad9a8c4847b186a7211 Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Thu, 20 Feb 2025 11:28:58 +0100 Subject: [PATCH 5/8] feedback fies pt2 --- addon/components/o-s-s/empty-state.hbs | 2 +- addon/components/o-s-s/empty-state.stories.js | 28 +++++++++++++++-- addon/components/o-s-s/empty-state.ts | 4 ++- .../components/o-s-s/empty-state-test.ts | 31 +++++++++++++++---- 4 files changed, 55 insertions(+), 10 deletions(-) diff --git a/addon/components/o-s-s/empty-state.hbs b/addon/components/o-s-s/empty-state.hbs index e7ab9343..cdb90ed7 100644 --- a/addon/components/o-s-s/empty-state.hbs +++ b/addon/components/o-s-s/empty-state.hbs @@ -1,4 +1,4 @@ -
+
{{#if (has-block "image")}} {{yield to="image"}} {{else if @badgeIcon}} diff --git a/addon/components/o-s-s/empty-state.stories.js b/addon/components/o-s-s/empty-state.stories.js index ef5381d1..99bc5da0 100644 --- a/addon/components/o-s-s/empty-state.stories.js +++ b/addon/components/o-s-s/empty-state.stories.js @@ -15,7 +15,7 @@ export default { control: { type: 'text' } }, title: { - description: 'The title of the state', + description: 'A title displayed below the icon or badge in the component', table: { type: { summary: 'string' @@ -25,7 +25,7 @@ export default { control: { type: 'text' } }, subtitle: { - description: 'More information about the state', + description: 'A subtitle displayed under the title in the component', table: { type: { summary: 'string' @@ -67,5 +67,29 @@ const Template = (args) => ({ context: args }); +const ImageTemplate = (args) => ({ + template: hbs` + <:image> + + + `, + context: args +}); + +const ActionTemplate = (args) => ({ + template: hbs` + <:actions> + + + `, + context: args +}); + export const Default = Template.bind({}); Default.args = defaultArgs; + +export const UsageWithImage = ImageTemplate.bind({}); +UsageWithImage.args = defaultArgs; + +export const UsageWithActions = ActionTemplate.bind({}); +UsageWithActions.args = defaultArgs; diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts index 8cdf210d..060a4291 100644 --- a/addon/components/o-s-s/empty-state.ts +++ b/addon/components/o-s-s/empty-state.ts @@ -8,12 +8,14 @@ interface OSSEmptyStateComponentSignature { size?: 'sm' | 'md'; } +const ALLOWED_SIZE = ['sm', 'md']; + export default class OSSEmptyStateComponent extends Component { get titleSize(): string { return this.size === 'sm' ? 'md' : 'lg'; } get size(): string { - return this.args.size && ['sm', 'md'].includes(this.args.size) ? this.args.size : 'md'; + return this.args.size && ALLOWED_SIZE.includes(this.args.size) ? this.args.size : 'md'; } } diff --git a/tests/integration/components/o-s-s/empty-state-test.ts b/tests/integration/components/o-s-s/empty-state-test.ts index af7e03d4..87830174 100644 --- a/tests/integration/components/o-s-s/empty-state-test.ts +++ b/tests/integration/components/o-s-s/empty-state-test.ts @@ -22,7 +22,7 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('.upf-badge').exists(); }); - test('it supports block usage for image', async function (assert) { + test('it supports named-block usage for image', async function (assert) { await render(hbs` <:image> @@ -36,7 +36,7 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('img').exists(); }); - test('it supports block usage for actions', async function (assert) { + test('it supports named-block usage for actions', async function (assert) { await render(hbs` <:actions> @@ -50,9 +50,28 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('button').hasText('Retry'); }); - test('it applies size-based styles', async function (assert) { - await render(hbs``); - assert.dom('div.font-color-gray-900').hasClass('font-size-md'); - assert.dom('div.font-color-gray-500').hasClass('font-size-sm'); + module('component size', function (hooks) { + test('it applies md sizes by default', async function (assert) { + await render(hbs``); + assert.dom('div.font-color-gray-900').hasClass('font-size-lg'); + assert.dom('div.font-color-gray-500').hasClass('font-size-md'); + }); + test('it applies md sizes when given a wrong size', async function (assert) { + await render(hbs``); + assert.dom('div.font-color-gray-900').hasClass('font-size-lg'); + assert.dom('div.font-color-gray-500').hasClass('font-size-md'); + }); + + test('it applies md sizes when specified', async function (assert) { + await render(hbs``); + assert.dom('div.font-color-gray-900').hasClass('font-size-lg'); + assert.dom('div.font-color-gray-500').hasClass('font-size-md'); + }); + + test('it applies sm sizes when specified', async function (assert) { + await render(hbs``); + assert.dom('div.font-color-gray-900').hasClass('font-size-md'); + assert.dom('div.font-color-gray-500').hasClass('font-size-sm'); + }); }); }); From 1eb5b71a761df88825f199ed8a2c7ab731e6352b Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Thu, 20 Feb 2025 17:04:49 +0100 Subject: [PATCH 6/8] feedback fixes pt3 --- addon/components/o-s-s/empty-state.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts index 060a4291..a4d6feb5 100644 --- a/addon/components/o-s-s/empty-state.ts +++ b/addon/components/o-s-s/empty-state.ts @@ -8,7 +8,7 @@ interface OSSEmptyStateComponentSignature { size?: 'sm' | 'md'; } -const ALLOWED_SIZE = ['sm', 'md']; +const ALLOWED_SIZES: string[] = ['sm', 'md']; export default class OSSEmptyStateComponent extends Component { get titleSize(): string { @@ -16,6 +16,6 @@ export default class OSSEmptyStateComponent extends Component Date: Fri, 21 Feb 2025 11:11:05 +0100 Subject: [PATCH 7/8] feedback fixes pt4 --- addon/components/o-s-s/empty-state.ts | 8 +++++++ .../components/o-s-s/empty-state-test.ts | 21 ++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/addon/components/o-s-s/empty-state.ts b/addon/components/o-s-s/empty-state.ts index a4d6feb5..59016f01 100644 --- a/addon/components/o-s-s/empty-state.ts +++ b/addon/components/o-s-s/empty-state.ts @@ -1,4 +1,5 @@ import type { htmlSafe } from '@ember/template'; +import { assert } from '@ember/debug'; import Component from '@glimmer/component'; interface OSSEmptyStateComponentSignature { @@ -11,6 +12,13 @@ interface OSSEmptyStateComponentSignature { const ALLOWED_SIZES: string[] = ['sm', 'md']; export default class OSSEmptyStateComponent extends Component { + constructor(owner: unknown, args: OSSEmptyStateComponentSignature) { + super(owner, args); + + assert('[component][OSS::EmptyState] The title parameter is mandatory', typeof args.title === 'string'); + assert('[component][OSS::EmptyState] The subtitle parameter is mandatory', typeof args.subtitle === 'string'); + } + get titleSize(): string { return this.size === 'sm' ? 'md' : 'lg'; } diff --git a/tests/integration/components/o-s-s/empty-state-test.ts b/tests/integration/components/o-s-s/empty-state-test.ts index 87830174..d0a5e201 100644 --- a/tests/integration/components/o-s-s/empty-state-test.ts +++ b/tests/integration/components/o-s-s/empty-state-test.ts @@ -1,6 +1,6 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; -import { render } from '@ember/test-helpers'; +import { render, setupOnerror } from '@ember/test-helpers'; import { hbs } from 'ember-cli-htmlbars'; module('Integration | Component | o-s-s/empty-state', function (hooks) { @@ -56,6 +56,7 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('div.font-color-gray-900').hasClass('font-size-lg'); assert.dom('div.font-color-gray-500').hasClass('font-size-md'); }); + test('it applies md sizes when given a wrong size', async function (assert) { await render(hbs``); assert.dom('div.font-color-gray-900').hasClass('font-size-lg'); @@ -74,4 +75,22 @@ module('Integration | Component | o-s-s/empty-state', function (hooks) { assert.dom('div.font-color-gray-500').hasClass('font-size-sm'); }); }); + + module('error management', function (hooks) { + test('it throws an error if the @title parameter is not passed', async function (assert) { + setupOnerror((err: any) => { + assert.equal(err.message, 'Assertion Failed: [component][OSS::EmptyState] The title parameter is mandatory'); + }); + + await render(hbs``); + }); + + test('it throws an error if the @subtitle parameter is not passed', async function (assert) { + setupOnerror((err: any) => { + assert.equal(err.message, 'Assertion Failed: [component][OSS::EmptyState] The subtitle parameter is mandatory'); + }); + + await render(hbs``); + }); + }); }); From 0b35d25be975cd00bc976257bec9564abd44d2b0 Mon Sep 17 00:00:00 2001 From: Hugues Coulard Date: Fri, 21 Feb 2025 14:27:02 +0100 Subject: [PATCH 8/8] fixing typo --- addon/components/o-s-s/empty-state.stories.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/o-s-s/empty-state.stories.js b/addon/components/o-s-s/empty-state.stories.js index 99bc5da0..5277e950 100644 --- a/addon/components/o-s-s/empty-state.stories.js +++ b/addon/components/o-s-s/empty-state.stories.js @@ -5,7 +5,7 @@ export default { component: 'empty state', argTypes: { badgeIcon: { - description: 'a font-awesome icon to be displayed in a badge', + description: 'A font-awesome icon to be displayed in a badge', table: { type: { summary: 'string' @@ -49,7 +49,7 @@ export default { parameters: { docs: { description: { - component: 'An component used when there is nothing to display on a page' + component: 'A component used when there is nothing to display on a page' } } }