Added borderless attr for power select #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
approved these changes
Mar 10, 2025
| @@ -1,5 +1,5 @@ | |||
| <div | |||
| class="upf-power-select fx-1 fx-col" | |||
| class="upf-power-select fx-1 fx-col {{if @borderless 'borderless'}}" | |||
There was a problem hiding this comment.
Suggested change
| class="upf-power-select fx-1 fx-col {{if @borderless 'borderless'}}" | |
| class="upf-power-select fx-1 fx-col {{if @borderless 'upf-power-select--borderless'}}" |
To better respect the BEM, maybe more upf-power-select--borderless
app/styles/power-select.less
Outdated
| @@ -16,6 +16,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| &.borderless { | |||
There was a problem hiding this comment.
Suggested change
| &.borderless { | |
| &--borderless { |
| </OSS::PowerSelect> | ||
| `); | ||
|
|
||
| assert.dom('.upf-power-select').hasClass('borderless'); |
There was a problem hiding this comment.
Suggested change
| assert.dom('.upf-power-select').hasClass('borderless'); | |
| assert.dom('.upf-power-select').hasClass('upf-power-select--borderless'); |
Miexil
reviewed
Mar 10, 2025
| @@ -40,6 +40,16 @@ export default { | |||
| }, | |||
| control: { type: 'boolean' } | |||
| }, | |||
| borderless: { | |||
| description: 'Display border of the component', | |||
There was a problem hiding this comment.
"Hide the border around the dropdown component"
Miexil
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #
What are the observable changes?
Good PR checklist