lib/go/thrift: Make the processor return success only if the response was successfully sent back

AlexisMontagne · AlexisMontagne · commit 952ae2dd48ed · 2023-11-02T15:59:25.000-07:00
diff --git a/lib/go/thrift/processor.go b/lib/go/thrift/processor.go
@@ -186,17 +186,18 @@ func (p *TBinaryProcessorFunction) Process(ctx Context, seqID int32, in, out TPr
 			tid = INTERNAL_TIME_OUT_ERROR
 		}
 
-		p.writeException(
+		rerr := p.writeException(
 			out,
 			seqID,
 			int32(tid),
 			fmt.Sprintf("Internal error processing : %s: %s", p.fname, err.Error()),
 		)
 
-		return true, err
+		return rerr == nil, err
 	}
 
-	return true, p.writeReply(out, seqID, res)
+	rerr := p.writeReply(out, seqID, res)
+	return rerr == nil, rerr
 }
 
 type TUnaryHandler interface {

Original file line number	Diff line number	Diff line change
`@@ -186,17 +186,18 @@ func (p *TBinaryProcessorFunction) Process(ctx Context, seqID int32, in, out TPr`
`186`	`186`	`tid = INTERNAL_TIME_OUT_ERROR`
`187`	`187`	`}`
`188`	`188`
`189`		`- p.writeException(`
	`189`	`+ rerr := p.writeException(`
`190`	`190`	`out,`
`191`	`191`	`seqID,`
`192`	`192`	`int32(tid),`
`193`	`193`	`fmt.Sprintf("Internal error processing : %s: %s", p.fname, err.Error()),`
`194`	`194`	`)`
`195`	`195`
`196`		`- return true, err`
	`196`	`+ return rerr == nil, err`
`197`	`197`	`}`
`198`	`198`
`199`		`- return true, p.writeReply(out, seqID, res)`
	`199`	`+ rerr := p.writeReply(out, seqID, res)`
	`200`	`+ return rerr == nil, rerr`
`200`	`201`	`}`
`201`	`202`
`202`	`203`	`type TUnaryHandler interface {`