Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mac arm build #11

Merged
merged 1 commit into from
Jun 5, 2024
Merged

add mac arm build #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
name: Build the thrift compiler
strategy:
matrix:
os: [ubuntu-20.04, macos-12]
os: [ubuntu-20.04, macos-12, macos-14]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is macos-14 always a arm machine? not a intel one 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes => https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ and it can also be confirmed on the runner details

Current runner version: '2.316.1' Operating System Runner Image Image: macos-14-arm[6](https://github.com/upfluence/thrift/actions/runs/9370263535/job/25796793876?pr=11#step:1:7)4

runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand Down Expand Up @@ -53,6 +53,10 @@ jobs:
with:
name: thrift-macos-12
path: bin/
- uses: actions/download-artifact@v2
with:
name: thrift-macos-14
path: bin/
- name: Get Package Version
id: pkg_version
run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/v}
Expand Down
Loading