-
Notifications
You must be signed in to change notification settings - Fork 42
Add option to reverse the day/month sidebar orientation #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Morgan Davies <25231953+M-Davies@users.noreply.github.com>
Thank you! It seems that we have to pass the setting field: diff --git a/src/plugin/ui/index.ts b/src/plugin/ui/index.ts
index f7ed24e..2ce052c 100644
--- a/src/plugin/ui/index.ts
+++ b/src/plugin/ui/index.ts
@@ -29,6 +29,7 @@ export class ReminderPluginUI {
this.plugin.app.workspace,
this.plugin.reminders,
this.plugin.settings.reminderTime,
+ this.plugin.settings.reverseSidebarGroupFormat,
// On select a reminder in the list
(reminder) => {
if (reminder.muteNotification) { Also, please run the |
By the way, I'm struggling with how to handle these date formats. It seems the obsidian-reminder-plugin has the following date displays:
It feels like a bit too much to introduce individual settings for each of these. On the other hand, I'm not sure if a single setting like |
I'm trying to implement the feature with 3 additional settings. obsidian-reminder/src/model/reminder.ts Lines 181 to 217 in 4378a23
|
I understand that having individual settings for each of these might be too much. However, the way the latter three are currently displayed seems arbitrary and deviates from Obsidian standards. How about using the existing "Date" setting, which includes day, month and year, and just truncating it for the other settings:
(Day of the week could be optional for the sidebar header via a checkbox) |
Closes: #224